From: Jason Wang <jasowang@redhat.com>
To: Zhu Lingshan <lingshan.zhu@intel.com>,
mst@redhat.com, alex.williamson@redhat.com
Cc: linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
netdev@vger.kernel.org, dan.daly@intel.com,
cunming.liang@intel.com, tiwei.bie@intel.com,
jason.zeng@intel.com, zhiyuan.lv@intel.com
Subject: Re: [RFC V4 2/2] This commit introduced IFC operations for vdpa
Date: Mon, 25 Nov 2019 16:19:46 +0800 [thread overview]
Message-ID: <f4cd7ba4-953e-872a-42bd-aa1303c18458@redhat.com> (raw)
In-Reply-To: <1574241431-24792-3-git-send-email-lingshan.zhu@intel.com>
On 2019/11/20 下午5:17, Zhu Lingshan wrote:
> +
> + if (!strcmp(kobj->name, "ifcvf-virtio_mdev"))
> + mdev_virtio_set_class_id(mdev,MDEV_VIRTIO_CLASS_ID_VIRTIO);
> +
> + if (!strcmp(kobj->name, "ifcvf-vhost_mdev"))
> + mdev_virtio_set_class_id(mdev,MDEV_VIRTIO_CLASS_ID_VHOST);
> +
> + mdev_set_drvdata(mdev, adapter);
> + mdev_set_iommu_device(mdev_dev(mdev), dev);
> + adapter->mdev_count--;
> +
To avoid confusion, it's better to call mdev_set_iommu_device() only for
the case of vhost. For virtio, it doesn't depends on that to work.
Thanks
prev parent reply other threads:[~2019-11-25 8:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 9:17 [RFC V4 0/2] Intel IFC VF driver for VDPA Zhu Lingshan
2019-11-20 9:17 ` [RFC V4 1/2] This commit introduced ifcvf_base layer Zhu Lingshan
2019-11-20 9:17 ` [RFC V4 2/2] This commit introduced IFC operations for vdpa Zhu Lingshan
2019-11-25 8:19 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4cd7ba4-953e-872a-42bd-aa1303c18458@redhat.com \
--to=jasowang@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=cunming.liang@intel.com \
--cc=dan.daly@intel.com \
--cc=jason.zeng@intel.com \
--cc=kvm@vger.kernel.org \
--cc=lingshan.zhu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=tiwei.bie@intel.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=zhiyuan.lv@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).