From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 772C6C282C4 for ; Mon, 4 Feb 2019 23:06:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3E2922082E for ; Mon, 4 Feb 2019 23:06:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EjzNN95z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727587AbfBDXGh (ORCPT ); Mon, 4 Feb 2019 18:06:37 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:43002 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726542AbfBDXGh (ORCPT ); Mon, 4 Feb 2019 18:06:37 -0500 Received: by mail-wr1-f65.google.com with SMTP id q18so1689876wrx.9 for ; Mon, 04 Feb 2019 15:06:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=g6rGr8A+QmxmjRCap9Cxk0Jjr9bHUwhZP1GjtDyMsOU=; b=EjzNN95zQMCMwNuIHwekeb9e2DS8brU9i3ZGW4i03QQxdsbCKwkW1Yg49WGnkAlJmw K9gGcXItOVchEsaxD61J1vZHThuVzmraHiOnCDCsIm2K+dDIpX3X4/T2nga+jbcxn3zf fsv//lEjPtT64j2TiZ7fp3lkdff1AWVTDnbzsX6NLwcr+MB/7NBzetXJWipzJ6YQJkRR o/qL5TEznOOkxLuVuVLBUah9FuFnywzv8khkyIGnSz/LSyNGZCxSwnXyd6f/NRt33o1n 5UCvOCPtaurM5Nw6U5MCpum1RlBIiTx9ghiGobv+6a0Mvgr97ejYseiX80MmDTjH9IkR DLJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=g6rGr8A+QmxmjRCap9Cxk0Jjr9bHUwhZP1GjtDyMsOU=; b=GA3iftULgY3Z0ee24sMN8pMIzWuy/QZnerwF72YMmW2HdUbf73/K4u9hkNy9JEmDr3 T/6QO9rxxJFUpByOIj4auaX6BzjLVWAaLi6HdjBsE+xXRhQBuIbmfiXM+iqDN1cZ6I64 c6C7nnA4zC4baYdgck3EEF5fH1ZxHu4PL9at/aAILGNniBNAj+3YN0QZ2ZnB8TWwY+iD jnPyDTA0tfslFtdSNexnekCfI9L7VKnkgdy/gYyfJAcgUecu0QlDExshqd+lDv3kuqhx ID7qJ4UPnsIypHtZb04MWCggZJhTF6InmW2V1cUL9r/Tw4h61l1B+RsIlGZ8go5j0M5x yyrg== X-Gm-Message-State: AHQUAuY8yXWdWk8kKa7qFYr+N6wwPOrQS9JVCrlM6QAeTmMNJF3y9pn1 7LlL0LGkIHWW411a24/ejMD+qvvn X-Google-Smtp-Source: AHgI3IZMkubVapqVxJuAsUlr70diFTnY4KHfnCOXdngmg6Z+TqpFI1gix3fHdtn9XmvuKpWvfFT+aQ== X-Received: by 2002:a5d:438a:: with SMTP id i10mr1219144wrq.111.1549321595393; Mon, 04 Feb 2019 15:06:35 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:79d1:9f16:256f:82a8? (p200300EA8BF1E20079D19F16256F82A8.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:79d1:9f16:256f:82a8]) by smtp.googlemail.com with ESMTPSA id d16sm6317375wrx.11.2019.02.04.15.06.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Feb 2019 15:06:34 -0800 (PST) Subject: Re: [PATCH 1/3 net-next] net: phy: aquantia: improve setting speed and duplex in aqr_read_status To: Andrew Lunn Cc: Florian Fainelli , David Miller , Nikita Yushchenko , "netdev@vger.kernel.org" References: <8e41695d-a23e-adad-ae3d-66a46d1ab077@gmail.com> <20190204212832.GB3397@lunn.ch> <20190204222348.GD3397@lunn.ch> From: Heiner Kallweit Message-ID: Date: Tue, 5 Feb 2019 00:06:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20190204222348.GD3397@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 04.02.2019 23:23, Andrew Lunn wrote: >> I'd like to use standard registers wherever possible. This patch is >> meant as a quick win to improve what we do already in aqr_read_status. >> Once we have a generic c45 read_status function we should switch to it. > > Hi Heiner > > I don't see much point in adding code which we know we are soon going > to replace. Just replace it. > OK, let me have a closer look at the other patches you sent me. To test them I need to get my DTU running first. And I need to check what happens if certain standard registers don't report what they should and how to deal with this. E.g. the AQCS109 according to the datasheet reports in the speed ability register that it is 10G-capable, what it is not. >> However I assume that information like interface mode we still have >> to read from vendor registers. > > For the Aquantia PHY, yes. It appears the Marvell PHY does not have > any registers which indicate this, so it uses heuristics based on the > link speed. > > Andrew > Heiner