From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Christian Marangi <ansuelsmth@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Gregory Clement <gregory.clement@bootlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
John Crispin <john@phrozen.org>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Lee Jones <lee@kernel.org>,
linux-leds@vger.kernel.org
Subject: Re: [net-next PATCH 10/11] dt-bindings: net: phy: Document support for LEDs node
Date: Wed, 8 Mar 2023 19:56:08 +0100 [thread overview]
Message-ID: <f51dc491-d151-6e8e-1ed7-70ecf0a8b2aa@linaro.org> (raw)
In-Reply-To: <ffb11c8b-be03-4ae3-6970-cf4bb21587e7@linaro.org>
On 08/03/2023 12:00, Krzysztof Kozlowski wrote:
> On 07/03/2023 18:00, Christian Marangi wrote:
>> Document support for LEDs node in phy and add an example for it.
>> PHY LED will have to match led pattern and should be treated as a
>> generic led.
>>
>> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
>> ---
>
> Also missing changelog, history, tags, anything. This was already v8.
>
> Also, I have doubts that your patchset is fully bisectable. Are you sure
> of this?
OK, so the leds in previous patch are not for phy but for port, so it is
properly bisectable.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-08 18:56 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 17:00 [net-next PATCH 00/11] net: Add basic LED support for switch/phy Christian Marangi
2023-03-07 17:00 ` [net-next PATCH 01/11] net: dsa: qca8k: add LEDs basic support Christian Marangi
2023-03-07 23:16 ` Andrew Lunn
2023-03-07 17:57 ` Christian Marangi
2023-03-08 0:49 ` Andrew Lunn
2023-03-07 19:41 ` Christian Marangi
2023-03-08 1:07 ` Andrew Lunn
2023-03-16 22:07 ` kernel test robot
2023-03-07 17:00 ` [net-next PATCH 02/11] net: dsa: qca8k: add LEDs blink_set() support Christian Marangi
2023-03-07 23:16 ` Andrew Lunn
2023-03-07 17:00 ` [net-next PATCH 03/11] net: phy: Add a binding for PHY LEDs Christian Marangi
2023-03-07 23:17 ` Andrew Lunn
2023-03-07 18:00 ` Christian Marangi
2023-03-08 0:54 ` Andrew Lunn
2023-03-07 17:00 ` [net-next PATCH 04/11] net: phy: phy_device: Call into the PHY driver to set LED brightness Christian Marangi
2023-03-07 17:00 ` [net-next PATCH 05/11] net: phy: marvell: Add software control of the LEDs Christian Marangi
2023-03-07 17:00 ` [net-next PATCH 06/11] net: phy: phy_device: Call into the PHY driver to set LED blinking Christian Marangi
2023-03-07 17:00 ` [net-next PATCH 07/11] net: phy: marvell: Implement led_blink_set() Christian Marangi
2023-03-07 17:00 ` [net-next PATCH 08/11] dt-bindings: net: dsa: dsa-port: Document support for LEDs node Christian Marangi
2023-03-08 1:00 ` Andrew Lunn
2023-03-08 18:58 ` Krzysztof Kozlowski
2023-03-07 17:00 ` [net-next PATCH 09/11] dt-bindings: net: dsa: qca8k: add LEDs definition example Christian Marangi
2023-03-08 10:58 ` Krzysztof Kozlowski
2023-03-08 13:57 ` Andrew Lunn
2023-03-08 18:49 ` Krzysztof Kozlowski
2023-03-08 19:02 ` Christian Marangi
2023-03-08 19:09 ` Krzysztof Kozlowski
2023-03-08 19:23 ` Christian Marangi
2023-03-08 19:42 ` Andrew Lunn
2023-03-07 17:00 ` [net-next PATCH 10/11] dt-bindings: net: phy: Document support for LEDs node Christian Marangi
2023-03-08 1:01 ` Andrew Lunn
2023-03-08 11:00 ` Krzysztof Kozlowski
2023-03-08 18:56 ` Krzysztof Kozlowski [this message]
2023-03-08 18:56 ` Krzysztof Kozlowski
2023-03-08 19:03 ` Christian Marangi
2023-03-07 17:00 ` [net-next PATCH 11/11] arm: mvebu: dt: Add PHY LED support for 370-rd WAN port Christian Marangi
2023-03-07 23:20 ` Andrew Lunn
2023-03-07 18:03 ` Christian Marangi
2023-03-08 1:20 ` [net-next PATCH 00/11] net: Add basic LED support for switch/phy Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f51dc491-d151-6e8e-1ed7-70ecf0a8b2aa@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=john@phrozen.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).