Netdev List
 help / color / mirror / Atom feed
From: Fernando Fernandez Mancera <fmancera@suse.de>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
	horms@kernel.org, pabeni@redhat.com, edumazet@google.com,
	dsahern@kernel.org, davem@davemloft.net
Subject: Re: [PATCH 3/3 net-next v4] selftests: net: add test for IPv4 devconf netlink notifications
Date: Fri, 15 May 2026 10:02:50 +0200	[thread overview]
Message-ID: <f528360c-18b3-46e5-8ba8-88f921203716@suse.de> (raw)
In-Reply-To: <20260514162429.366b94c9@kernel.org>

On 5/15/26 1:24 AM, Jakub Kicinski wrote:
> On Thu, 14 May 2026 11:42:16 +0200 Fernando Fernandez Mancera wrote:
>> On 5/14/26 4:35 AM, Jakub Kicinski wrote:
>>> On Sun, 10 May 2026 10:15:28 +0200 Fernando Fernandez Mancera wrote:
>>>> Introduce a new test, `ipv4_devconf_notify`, to verify that the kernel
>>>> sends the appropriate netlink notifications when IPv4 devconf parameters
>>>> are modified.
>>>>
>>>> Since YNL currently has a bug where it declares an array of u32 values
>>>> instead of the nested attributes expected by the kernel for devconf set
>>>> operations, a temporary hack (`patched_add_attr`) is included to
>>>> pack the netlink attributes correctly.
>>>
>>> Right, YNL doesn't really support the level or weirdness that netconf
>>> requires. Why use YNL? Can't we test this with iproute2?
>>
>> No, AFAIU, iproute2 does not expose devconf settings. The main user of
>> IFLA_INET_CONF are netlink libraries and other userspace tools that
>> heavily rely on netlink operations like NetworkManager, nmstate, nispor,
>> rust-netlink..
> 
> Isn't this ip netconf ?
> 

Oh sorry, I should have clarified it. ip netconf only shows/query them 
but it cannot set them AFAICS.

Usage: ip netconf show [ dev STRING ]

>> FWIW, I plan to fix the YNL side of things so we have this fixed
>> properly.
> 
> If it adds any hacks or new concepts to YNL it's unlikely to
> be accepted :(
> 
>> But I would prefer if this isn't blocked. Another patchset
>> introducing IFLA_INET6_CONF support is also coming.. being able to avoid
>> sysctl usage is quite useful for these userspace tools.
> 


      reply	other threads:[~2026-05-15  8:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-10  8:15 [PATCH 1/3 net-next v4] ipv4: centralize devconf sysctl handling Fernando Fernandez Mancera
2026-05-10  8:15 ` [PATCH 2/3 net-next v4] ipv4: handle devconf post-set actions on netlink updates Fernando Fernandez Mancera
2026-05-14  2:30   ` Jakub Kicinski
2026-05-14  9:16     ` Fernando Fernandez Mancera
2026-05-10  8:15 ` [PATCH 3/3 net-next v4] selftests: net: add test for IPv4 devconf netlink notifications Fernando Fernandez Mancera
2026-05-14  2:35   ` Jakub Kicinski
2026-05-14  9:42     ` Fernando Fernandez Mancera
2026-05-14 23:24       ` Jakub Kicinski
2026-05-15  8:02         ` Fernando Fernandez Mancera [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f528360c-18b3-46e5-8ba8-88f921203716@suse.de \
    --to=fmancera@suse.de \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox