From: Alexei Starovoitov <ast@fb.com>
To: Daniel Borkmann <daniel@iogearbox.net>, <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 2/2] bpf: inline map in map lookup functions for array and htab
Date: Fri, 18 Aug 2017 17:05:10 -0700 [thread overview]
Message-ID: <f5309f0a-b647-c759-e0c0-efdf5a1d8002@fb.com> (raw)
In-Reply-To: <501683f73390c81a7abaa0683f3675860a79adc7.1503100047.git.daniel@iogearbox.net>
On 8/18/17 4:51 PM, Daniel Borkmann wrote:
> Avoid two successive functions calls for the map in map lookup, first
> is the bpf_map_lookup_elem() helper call, and second the callback via
> map->ops->map_lookup_elem() to get to the map in map implementation.
> Implementation inlines array and htab flavor for map in map lookups.
>
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
lgtm
thanks for adding this optimization.
Acked-by: Alexei Starovoitov <ast@kernel.org>
prev parent reply other threads:[~2017-08-19 0:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-18 23:51 [PATCH net-next 0/2] BPF inline improvements Daniel Borkmann
2017-08-18 23:51 ` [PATCH net-next 1/2] bpf: improve htab inlining for future 32 bit jits Daniel Borkmann
2017-08-19 0:00 ` Alexei Starovoitov
2017-08-19 0:21 ` Daniel Borkmann
2017-08-19 0:24 ` Alexei Starovoitov
2017-08-18 23:51 ` [PATCH net-next 2/2] bpf: inline map in map lookup functions for array and htab Daniel Borkmann
2017-08-19 0:05 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5309f0a-b647-c759-e0c0-efdf5a1d8002@fb.com \
--to=ast@fb.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).