* [PATCH net-next] net: Use __u32 in uapi net_stamp.h
@ 2018-07-09 23:08 Jesus Sanchez-Palencia
2018-07-09 23:18 ` Eric Dumazet
0 siblings, 1 reply; 3+ messages in thread
From: Jesus Sanchez-Palencia @ 2018-07-09 23:08 UTC (permalink / raw)
To: netdev; +Cc: davem, eric.dumazet, Jesus Sanchez-Palencia
We are not supposed to use u32 in uapi, so change the flags member of
struct sock_txtime from u32 to __u32 instead.
Fixes: 80b14dee2bea ("net: Add a new socket option for a future transmit time")
Signed-off-by: Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com>
---
include/uapi/linux/net_tstamp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/net_tstamp.h b/include/uapi/linux/net_tstamp.h
index f8f4539f1135..bdae4806fe40 100644
--- a/include/uapi/linux/net_tstamp.h
+++ b/include/uapi/linux/net_tstamp.h
@@ -156,7 +156,7 @@ enum txtime_flags {
struct sock_txtime {
clockid_t clockid; /* reference clockid */
- u32 flags; /* flags defined by enum txtime_flags */
+ __u32 flags; /* flags defined by enum txtime_flags */
};
#endif /* _NET_TIMESTAMPING_H */
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: Use __u32 in uapi net_stamp.h
2018-07-09 23:08 [PATCH net-next] net: Use __u32 in uapi net_stamp.h Jesus Sanchez-Palencia
@ 2018-07-09 23:18 ` Eric Dumazet
2018-07-09 23:20 ` Jesus Sanchez-Palencia
0 siblings, 1 reply; 3+ messages in thread
From: Eric Dumazet @ 2018-07-09 23:18 UTC (permalink / raw)
To: Jesus Sanchez-Palencia, netdev; +Cc: davem
On 07/09/2018 04:08 PM, Jesus Sanchez-Palencia wrote:
> We are not supposed to use u32 in uapi, so change the flags member of
> struct sock_txtime from u32 to __u32 instead.
>
> Fixes: 80b14dee2bea ("net: Add a new socket option for a future transmit time")
> Signed-off-by: Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com>
Could you use this patch as an opportunity to tab-align the fields names ?
Also you can credit the reporter, as in :
Reported-by: Eric Dumazet <edumazet@google.com>
Thanks !
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: Use __u32 in uapi net_stamp.h
2018-07-09 23:18 ` Eric Dumazet
@ 2018-07-09 23:20 ` Jesus Sanchez-Palencia
0 siblings, 0 replies; 3+ messages in thread
From: Jesus Sanchez-Palencia @ 2018-07-09 23:20 UTC (permalink / raw)
To: Eric Dumazet, netdev; +Cc: davem
On 07/09/2018 04:18 PM, Eric Dumazet wrote:
>
>
> On 07/09/2018 04:08 PM, Jesus Sanchez-Palencia wrote:
>> We are not supposed to use u32 in uapi, so change the flags member of
>> struct sock_txtime from u32 to __u32 instead.
>>
>> Fixes: 80b14dee2bea ("net: Add a new socket option for a future transmit time")
>> Signed-off-by: Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com>
>
> Could you use this patch as an opportunity to tab-align the fields names ?
>
> Also you can credit the reporter, as in :
>
> Reported-by: Eric Dumazet <edumazet@google.com>
>
Sure
> Thanks !
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-09 23:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-09 23:08 [PATCH net-next] net: Use __u32 in uapi net_stamp.h Jesus Sanchez-Palencia
2018-07-09 23:18 ` Eric Dumazet
2018-07-09 23:20 ` Jesus Sanchez-Palencia
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).