From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tariq Toukan <tariqt@mellanox.com>
Subject: Re: [net-next V8 PATCH 01/16] mlx5: basic XDP_REDIRECT forward
 support
Date: Sun, 1 Apr 2018 11:46:50 +0300
Message-ID: <f560395f-af4e-cf81-5085-c763e58ca429@mellanox.com>
References: <152249785004.28297.14544687552072300815.stgit@firesoul>
 <152249795210.28297.14005981548436322464.stgit@firesoul>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: eugenia@mellanox.com, Jason Wang <jasowang@redhat.com>,
        John Fastabend <john.fastabend@gmail.com>,
        Eran Ben Elisha <eranbe@mellanox.com>,
        Saeed Mahameed <saeedm@mellanox.com>, galp@mellanox.com,
        Daniel Borkmann <borkmann@iogearbox.net>,
        Alexei Starovoitov <alexei.starovoitov@gmail.com>,
        Tariq Toukan <tariqt@mellanox.com>
To: Jesper Dangaard Brouer <brouer@redhat.com>, netdev@vger.kernel.org,
        =?UTF-8?B?QmrDtnJuVMO2cGVs?= <bjorn.topel@intel.com>,
        magnus.karlsson@intel.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-he1eur01on0069.outbound.protection.outlook.com ([104.47.0.69]:4309
        "EHLO EUR01-HE1-obe.outbound.protection.outlook.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1750990AbeDAIrG (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sun, 1 Apr 2018 04:47:06 -0400
In-Reply-To: <152249795210.28297.14005981548436322464.stgit@firesoul>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 31/03/2018 3:05 PM, Jesper Dangaard Brouer wrote:

..

> @@ -844,6 +851,15 @@ static inline int mlx5e_xdp_handle(struct mlx5e_rq *rq,
>   		if (unlikely(!mlx5e_xmit_xdp_frame(rq, di, &xdp)))
>   			trace_xdp_exception(rq->netdev, prog, act);
>   		return true;
> +	case XDP_REDIRECT:
> +		/* When XDP enabled then page-refcnt==1 here */
> +		err = xdp_do_redirect(rq->netdev, &xdp, prog);
> +		if (!err) {
> +			rq->wqe.xdp_xmit = true; /* XDP xmit owns page */

boolean xdp_xmit does not exist anymore, it was removed recently by:
121e89275471 net/mlx5e: Refactor RQ XDP_TX indication

please replace with:
			__set_bit(MLX5E_RQ_FLAG_XDP_XMIT, rq->flags);

> +			rq->xdpsq.db.redirect_flush = true;
> +			mlx5e_page_dma_unmap(rq, di);
> +		}
> +		return true;
>   	default:
>   		bpf_warn_invalid_xdp_action(act);
>   	case XDP_ABORTED: