From: "Nambiar, Amritha" <amritha.nambiar@intel.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
jakub.kicinski@netronome.com, sridhar.samudrala@intel.com,
jhs@mojatatu.com, xiyou.wangcong@gmail.com
Subject: Re: [net-next PATCH v3] net: sched: cls_flower: Classify packets using port ranges
Date: Mon, 12 Nov 2018 15:54:47 -0800 [thread overview]
Message-ID: <f59d24e6-c4fa-0755-254f-eaec41f1cca2@intel.com> (raw)
In-Reply-To: <20181110071458.GA2019@nanopsycho.orion>
On 11/9/2018 11:14 PM, Jiri Pirko wrote:
> Sat, Nov 10, 2018 at 01:11:10AM CET, amritha.nambiar@intel.com wrote:
>
> [...]
>
>> @@ -1026,8 +1122,7 @@ static void fl_init_dissector(struct flow_dissector *dissector,
>> FLOW_DISSECTOR_KEY_IPV4_ADDRS, ipv4);
>> FL_KEY_SET_IF_MASKED(mask, keys, cnt,
>> FLOW_DISSECTOR_KEY_IPV6_ADDRS, ipv6);
>> - FL_KEY_SET_IF_MASKED(mask, keys, cnt,
>> - FLOW_DISSECTOR_KEY_PORTS, tp);
>> + FL_KEY_SET(keys, cnt, FLOW_DISSECTOR_KEY_PORTS, tp);
>
> You still need to set the key under a condition. Something like:
> if (FL_KEY_IS_MASKED(mask, tp) ||
> FL_KEY_IS_MASKED(mask, tp_min) ||
> FL_KEY_IS_MASKED(mask, tp_max)
> FL_KEY_SET(keys, cnt, FLOW_DISSECTOR_KEY_PORTS, tp);
>
Yes, will do. Thanks!
>
>> FL_KEY_SET_IF_MASKED(mask, keys, cnt,
>> FLOW_DISSECTOR_KEY_IP, ip);
>> FL_KEY_SET_IF_MASKED(mask, keys, cnt,
>
> [...]
>
prev parent reply other threads:[~2018-11-13 9:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-10 0:11 [net-next PATCH v3] net: sched: cls_flower: Classify packets using port ranges Amritha Nambiar
2018-11-10 7:14 ` Jiri Pirko
2018-11-12 23:54 ` Nambiar, Amritha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f59d24e6-c4fa-0755-254f-eaec41f1cca2@intel.com \
--to=amritha.nambiar@intel.com \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=sridhar.samudrala@intel.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).