From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH net] net: dsa: mt7530: Use NULL instead of plain integer Date: Tue, 3 Apr 2018 10:02:40 -0700 Message-ID: References: <20180402232414.19671-1-f.fainelli@gmail.com> <1522721904.18424.51.camel@mtkswgap22> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Andrew Lunn , Vivien Didelot , open list , linux-mediatek@lists.infradead.org To: Sean Wang Return-path: In-Reply-To: <1522721904.18424.51.camel@mtkswgap22> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 04/02/2018 07:18 PM, Sean Wang wrote: > On Mon, 2018-04-02 at 16:24 -0700, Florian Fainelli wrote: >> We would be passing 0 instead of NULL as the rsp argument to >> mt7530_fdb_cmd(), fix that. >> > > Acked-by: Sean Wang > > BTW, does the part of the commit message should be updated with "passing > NULL instead of 0"? I don't follow you, the commit message indicates what we were doing which implies it was wrong and fixes it. Would you want me to reword that part? -- Florian