Re: [PATCH wpan-next v3 1/4] net: ieee802154: ca8210: Fix lifs/sifs periods

[Stefan Schmidt <stefan@datenfreihafen.org>]

Hello.

On 01.02.22 19:06, Miquel Raynal wrote:
> These periods are expressed in time units (microseconds) while 40 and 12
> are the number of symbol durations these periods will last. We need to
> multiply them both with the symbol_duration in order to get these
> values in microseconds.
> 
> Fixes: ded845a781a5 ("ieee802154: Add CA8210 IEEE 802.15.4 device driver")
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>   drivers/net/ieee802154/ca8210.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c
> index f3438d3e104a..2bc730fd260e 100644
> --- a/drivers/net/ieee802154/ca8210.c
> +++ b/drivers/net/ieee802154/ca8210.c
> @@ -2975,8 +2975,8 @@ static void ca8210_hw_setup(struct ieee802154_hw *ca8210_hw)
>   	ca8210_hw->phy->cca.opt = NL802154_CCA_OPT_ENERGY_CARRIER_AND;
>   	ca8210_hw->phy->cca_ed_level = -9800;
>   	ca8210_hw->phy->symbol_duration = 16;
> -	ca8210_hw->phy->lifs_period = 40;
> -	ca8210_hw->phy->sifs_period = 12;
> +	ca8210_hw->phy->lifs_period = 40 * ca8210_hw->phy->symbol_duration;
> +	ca8210_hw->phy->sifs_period = 12 * ca8210_hw->phy->symbol_duration;
>   	ca8210_hw->flags =
>   		IEEE802154_HW_AFILT |
>   		IEEE802154_HW_OMIT_CKSUM |
> 

As mentioned in the discussion on the other thread I ripped this one out 
and applied it as fix to the wpan tree. Thanks!

regards
Stefan Schmidt