From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65688C282CE for ; Fri, 5 Apr 2019 23:38:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 12D5721726 for ; Fri, 5 Apr 2019 23:38:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RmVbsLyN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726264AbfDEXit (ORCPT ); Fri, 5 Apr 2019 19:38:49 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:42911 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726124AbfDEXis (ORCPT ); Fri, 5 Apr 2019 19:38:48 -0400 Received: by mail-pl1-f195.google.com with SMTP id cv12so3820651plb.9 for ; Fri, 05 Apr 2019 16:38:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=u2sBNgJRmizPtVlUesMUvQcxd0Qj+iKxTYH5yNlKsM0=; b=RmVbsLyN84vfvHNU+HwKS0c3dnA6jWWCMOwsKQsV3gxoFbvJAj1AFuXtObgqtayD4N ZYsqn9FhQ0lLP05uDmjolWCPloJKV/Sl+46vTnKrkzMA6vuKERdJqmr8ANPvMNnfT8+z sOXaVrVuLMhTo0Bj5QIp/3svTF2rTjuPrTrDBt+VTrFvD4ONmauVRUXL9akN4zLgRUjF 6WZcXFwcT0UxtJLDp2B0RMIcx1K9DCh/+p/q2DvzgVFvkIuHT93yeB9IhgtRIoBE3k0+ BZQJNrbCFEdkGfeHiiKBQIipDiwp3ArP9ugxA5dWPeXtZn634J46I+h/GUpRetBe+zL4 TUcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=u2sBNgJRmizPtVlUesMUvQcxd0Qj+iKxTYH5yNlKsM0=; b=N9yxxR1PoHDvoPGjMhSb4gKvA4mcmwosnNWpyd78/bOwr2tYdQ9pquBF55lMKbK0+4 i3MesEWrLKua608GeQ37PWTm8IBb83MNMmaqyTu2kGCPbRQGjllc4VjMyVFCA9gklZt3 VFuCyYkPKxxwP+FaUvYtuixoFNmD0487R9wcnzFrcRTKjkJVghtGLm1gsPyKH80GtSiy omrgQko1Pz3tBcMoy2xON2221PzLi5RGc3CUJ1WLa/F92bHaHp0chlIJIhajXz81czrg OjlxofJxMtqYUrty/jLoJRRfg8WslRYHvNmVZMnc00cxzfVuT7kjVtF++9ago/MWaGBa zO2g== X-Gm-Message-State: APjAAAUGwfnB+X3YshMesWGWaC6IB8mSeNB3RXc4TmOCvfXDjFaEivTC TP0lbjtcZoYZ+DTx8d6pFCY= X-Google-Smtp-Source: APXvYqyaM9t8OnGRKKYuqcOm5qL6s4U+Hly1AH41iIWHf0qa0EuoCEEY5MAWWfHiuKqj63geHWNIZg== X-Received: by 2002:a17:902:1008:: with SMTP id b8mr15574824pla.120.1554507528169; Fri, 05 Apr 2019 16:38:48 -0700 (PDT) Received: from [10.40.10.241] (fw.cumulusnetworks.com. [216.129.126.126]) by smtp.googlemail.com with ESMTPSA id h1sm10703279pgs.67.2019.04.05.16.38.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Apr 2019 16:38:47 -0700 (PDT) Subject: Re: [PATCH net-next 00/18] ipv4: Enable support for IPv6 gateway with IPv4 routes To: Ido Schimmel , David Ahern Cc: "davem@davemloft.net" , "netdev@vger.kernel.org" , Jiri Pirko References: <20190404175007.8150-1-dsahern@kernel.org> <20190405155640.GA3591@splinter> From: David Ahern Message-ID: Date: Fri, 5 Apr 2019 16:38:45 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190405155640.GA3591@splinter> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/5/19 8:56 AM, Ido Schimmel wrote: > Reviewed-by: Ido Schimmel > > I also ran some tests and it looks good. > > Great work! Thanks for the review. I fixed the typos and messages you pointed out. In v2 I also moved the fib6_nh_release in patch 9 to 'if (!err)' branch since the intention is that release is not called if the init fails.