From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.127 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795057564; b=SR+0mhSFUdsr2OLwJPBv3wSx2xIrQ2Z0zXzNmDvPyH2qUqwr1+Jzul4ATqTYMsSVqpdW 3Ln6ALcrBUG/UOEokWbxmERM9FInupMqLPkAmb711aVuzU5RZzY6D8ew23skT2+XaC2Cj wDvgKQd6ZNFLGJ16XV/ft29ElE4Qn0Fq3ZPysP4HaPxz9TDxfBjZ8cAuMCDWjI//sGb5S wLmP56SCOv9bsWndgFNBH6ze16C0A4XOKfCTklYjMVt3MBfjQLda3qAba5gS/f9QiZY6B nEwVI9VOHhs4I08DI9fwHfY5FWlNXGVnkxcgiIQRqmfYAoIkCzNNf1qV4joYbo2kxOg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795057564; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=1nQ8YaDGbdbSQt97QgB7GPkOItZkKsKE3rzuGdpJu68=; b=QOEcVU0LUvwtthjX+/fvJyvZxFIuM5DftTni+IKl7x4de7IRZ0MPyLzbH6Cjr9fT+9At SFM4s8Yv9Phd57TArwjdk82r6U0XK40OcB/z7npYAEbRHbSdyDxefdxwne0LxcXnXIe6f 6ldU3vYwrxaq8rPTEFbjqXWilyyFMin2hFckNe2p2UCen7Ayl5Zgt4UoQo0saYXWtYhkV VUzmJ2zOdNTU0caQDn/9gpZh9Qj6v4mzucZvEXL9vhL2uSQ/i0kKAsxCAu3v/h3qwrY+c zT7OuCNSD9jUUS1yhSW4knI3SAhRafskmFYKd+FSPak+7FINQdAkSSFtfVBS5zv/zjg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b="aj/17xhI"; arc=none smtp.remote-ip=91.218.175.127 Received: from mta0.migadu.com (out-127.mta0.migadu.com [91.218.175.127]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58D7B606A333 for ; Thu, 19 Nov 2026 03:06:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 58D7B606A333 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=aj/17xhI X-Envelope-To: netdev@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=Ysl+OVqX7d+ztep9qyZyfXqOyAiRMAJ0DrG8uvKUQMk=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1795057561; v=1; x=1795662361; b=aj/17xhIXphCEjqilT+2cb1FVryRHUM/0lHNhL9SjhGoP4XWnq6luQ47Z9W5AhPIhthQIhGz I9BOXHw7O9F0u0oTzTeZr9pr+lh0UHb9CmptH5iJvhClOMivrkR7+FZoVo3n3joNisiRnsH4qWF 1fy/3glAaG1+cwoCdFNhH/IQ= X-Envelope-To: netdev@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 3b965933bbe9266c; Thu, 19 Nov 2026 03:06:00 +0000 X-Mizu-Trace-ID: 3b965933bbe9266c X-Migadu-Flow: FLOW_OUT Message-ID: Date: Thu, 19 Nov 2026 12:05:48 +0900 X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v1] net/mlx5e: TX, Do not open a multi-packet WQE for a single packet To: Tariq Toukan Cc: saeedm@nvidia.com, leon@kernel.org, mbloch@nvidia.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Xuanqiang Luo , netdev@vger.kernel.org References: <20261117085036.3138779-1-xuanqiang.luo@linux.dev> <773ac747-b58b-45eb-8072-8f048da3c54f@nvidia.com> From: Xuanqiang Luo In-Reply-To: <773ac747-b58b-45eb-8072-8f048da3c54f@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2026/11/18 at 20:14 Tariq Toukan wrote: > > > On 17/11/2026 10:50, Xuanqiang Luo wrote: >> From: Xuanqiang Luo >> > > [...] > >> @@ -678,11 +679,13 @@ netdev_tx_t mlx5e_xmit(struct sk_buff *skb, >> struct net_device *dev) >>       mlx5e_sq_xmit_prepare(sq, skb, &accel, &attr); >>       if (test_bit(MLX5E_SQ_STATE_MPWQE, &sq->state)) { >> -        if (mlx5e_tx_skb_supports_mpwqe(skb, &attr)) { >> +        /* An MPWQE for a lone packet saves nothing, use a regular >> WQE. */ >> +        if (mlx5e_tx_skb_supports_mpwqe(skb, &attr) && >> +            (xmit_more || mlx5e_tx_mpwqe_session_is_active(sq))) { > > I'd swap the two conditions: > >     if ((xmit_more || mlx5e_tx_mpwqe_session_is_active(sq)) && >         mlx5e_tx_skb_supports_mpwqe(skb, &attr)) { > > A lone packet, which is the case you optimize, then skips the skb > checks, and it reads in the natural order: is there a batch to join, and > can this skb join it. > Makes sense, thanks for the suggestion. I will swap the conditions in v2. > Also, it's be nice if you could test for traffic that goes through the > stack, for example UDP_RR / TCP_RR and a UDP stream with netperf, in > addition to pktgen. I will run the tests again with the new code, including the ones you mentioned. Thanks! Xuanqiang