netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: "Oleksij Rempel" <o.rempel@pengutronix.de>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
	"Nicolas Saenz Julienne" <nsaenz@kernel.org>,
	"Ray Jui" <rjui@broadcom.com>, "Rob Herring" <robh+dt@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Scott Branden" <sbranden@broadcom.com>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Tony Lindgren" <tony@atomide.com>
Cc: kernel@pengutronix.de, bcm-kernel-feedback-list@broadcom.com,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: Re: [PATCH v3 4/8] ARM: dts: bcm283x: fix ethernet node name
Date: Tue, 15 Feb 2022 13:01:06 -0800	[thread overview]
Message-ID: <f5ea3375-0306-e37f-5847-e1472164d7b7@gmail.com> (raw)
In-Reply-To: <20220215080937.2263111-4-o.rempel@pengutronix.de>

On 2/15/22 12:09 AM, Oleksij Rempel wrote:
> It should be "ethernet@x" instead of "usbether@x"
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>

This looks like, a quick grep on the u-boot source code seems to suggest
that only one file is assuming that 'usbether@1' is to be used as a node
name and the error message does not even match the code it is patching:

board/liebherr/xea/xea.c:
  #ifdef CONFIG_OF_BOARD_SETUP
  static int fdt_fixup_l2switch(void *blob)
  {
          u8 ethaddr[6];
          int ret;

          if (eth_env_get_enetaddr("ethaddr", ethaddr)) {
                  ret = fdt_find_and_setprop(blob,

"/ahb@80080000/switch@800f0000",
                                             "local-mac-address",
ethaddr, 6, 1);
                  if (ret < 0)
                          printf("%s: can't find usbether@1 node: %d\n",
                                 __func__, ret);
          }

          return 0;
  }

I will wait for the other maintainers on the other patches to provide
some feedback, but if all is well, will apply this one soon.
-- 
Florian

  reply	other threads:[~2022-02-15 21:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-15  8:09 [PATCH v3 1/8] dt-bindings: net: add schema for ASIX USB Ethernet controllers Oleksij Rempel
2022-02-15  8:09 ` [PATCH v3 2/8] dt-bindings: net: add schema for Microchip/SMSC LAN95xx " Oleksij Rempel
2022-02-15  8:09 ` [PATCH v3 3/8] dt-bindings: usb: ci-hdrc-usb2: fix node node for ethernet controller Oleksij Rempel
2022-02-15  8:09 ` [PATCH v3 4/8] ARM: dts: bcm283x: fix ethernet node name Oleksij Rempel
2022-02-15 21:01   ` Florian Fainelli [this message]
2022-02-16  7:16     ` Oleksij Rempel
2022-02-15  8:09 ` [PATCH v3 5/8] ARM: dts: exynos: fix ethernet node name for different odroid boards Oleksij Rempel
2022-02-15  8:12   ` Marc Kleine-Budde
2022-02-15  8:16     ` Oleksij Rempel
2022-02-15 20:56       ` Andrew Lunn
2022-02-16  6:15         ` Oleksij Rempel
2022-02-15  8:28   ` Krzysztof Kozlowski
2022-02-15  8:09 ` [PATCH v3 6/8] ARM: dts: omap3/4/5: fix ethernet node name for different OMAP boards Oleksij Rempel
2022-02-15  8:09 ` [PATCH v3 7/8] ARM: dts: tegra20/30: fix ethernet node name for different tegra boards Oleksij Rempel
2022-02-15  8:09 ` [PATCH v3 8/8] arm64: dts: imx8mm-kontron: fix ethernet node name Oleksij Rempel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f5ea3375-0306-e37f-5847-e1472164d7b7@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bcousson@baylibre.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nsaenz@kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=rjui@broadcom.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=sbranden@broadcom.com \
    --cc=shawnguo@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).