From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0561C2F421 for ; Mon, 21 Jan 2019 14:56:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C16B120879 for ; Mon, 21 Jan 2019 14:56:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KgtCi9Ts" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729654AbfAUO40 (ORCPT ); Mon, 21 Jan 2019 09:56:26 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:46924 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729559AbfAUO40 (ORCPT ); Mon, 21 Jan 2019 09:56:26 -0500 Received: by mail-pl1-f193.google.com with SMTP id t13so9936094ply.13 for ; Mon, 21 Jan 2019 06:56:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Dp+/gNzQ4WJZa4/qllLPRfPc1f4ZBqAPw4BldolWnYQ=; b=KgtCi9Ts2UnzMHQ38vH5UXI45Jh0y4IhAVIqZaKzsC3MVShkrUTSU6flCBF1bJqo1o XRyK2N3de3ngV9hkYkr2M5uh7IPGFicEDDh9THDjXe5r6pbLMMrf10kQaUf+RjYPwRtd HHPvRWGYqv2R1gH62J40hvK1Y2Qg0gjORQz0dJtabiE0Xk3bgezfnAJs/KonInUpG8rr IG6q7frOP48ydMB8+Et7IKbzjb5r80ebkFIpBol67wm3MrDumrhhYOR+o38l2nq491K1 iOmwoJ+UPHHB6lf8XXLPv/84dDUHw4WyhaAzvN7/JGK7diZ6RjDcTIw9bShXjh1EoPLB uBeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Dp+/gNzQ4WJZa4/qllLPRfPc1f4ZBqAPw4BldolWnYQ=; b=AIZcY2OMhQu69oRelMil5LEmAweBJD8wmcG8xXN3/MrR7xQbPQWB/fnyrW0J/McLOr tzkUbqiQGvXLpVu/Dw/5zoev9wgcZiR+TEJi7E0CBtE3M9xLrQMSn6SiQ22l5hCKxR8O 8JqxoOW4aRtKIuitoxiDfyG0JAxVQNk0Zkcc8LwLfvLdv21QYtmP/KrY0rifZA9/x1uJ 3K0egnhaTauXHOgjkp7KCAuXhHhx/WG3WEL2OnW0XP7suXiYPn3wiBtnfjZD8hyXo+6m 5Cz2WDgOlqE4tKcxvlLzUhd0JbHSGs2UunWEoa+7gcK7JTtaxO4hcJvAk8HTVBiUwLWn 7vww== X-Gm-Message-State: AJcUukdw9TzI0F71alqJTMIT5q2tlFcQ4BV6k0MZlcVpG8JpDpzBP9Vu TAZg2FnoMFk+CJW6spWbbo2GTkZQ X-Google-Smtp-Source: ALg8bN54vj8F3jMQ3/DaD2pE15+SM8mHmKKa9q2p2RroDE2FYE/ZJmGL22lNTzOq9bktr8+WQeTaLQ== X-Received: by 2002:a17:902:724a:: with SMTP id c10mr30971149pll.51.1548082585648; Mon, 21 Jan 2019 06:56:25 -0800 (PST) Received: from ?IPv6:2601:282:800:fd80:d58c:9df2:49cf:9a2a? ([2601:282:800:fd80:d58c:9df2:49cf:9a2a]) by smtp.googlemail.com with ESMTPSA id v12sm14239202pgg.41.2019.01.21.06.56.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Jan 2019 06:56:24 -0800 (PST) Subject: Re: [PATCH iproute2] ip route: get: only set RTM_F_LOOKUP_TABLE flag for IPv4 To: Ido Schimmel Cc: Stephen Hemminger , Jakub Kicinski , netdev@vger.kernel.org, oss-drivers@netronome.com References: <20190112205406.25698-1-jakub.kicinski@netronome.com> <20190114080547.452b9915@hermes.lan> <24a5672e-a574-dfdc-3482-e86056e22939@gmail.com> <20190121073246.GA4717@splinter> From: David Ahern Message-ID: Date: Mon, 21 Jan 2019 07:56:22 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190121073246.GA4717@splinter> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/21/19 12:32 AM, Ido Schimmel wrote: > On Mon, Jan 14, 2019 at 09:29:51AM -0700, David Ahern wrote: >> On 1/14/19 9:05 AM, Stephen Hemminger wrote: >>> On Sat, 12 Jan 2019 12:54:06 -0800 >>> Jakub Kicinski wrote: >>> >>>> Kernel ignores the RTM_F_LOOKUP_TABLE flag for all families >>>> but IPv4. Don't set it, otherwise it may fall foul of >>>> strict checking policies. >>>> >>>> Signed-off-by: Jakub Kicinski >>> >>> Doing the right thing is a good idea, but really I can't see >>> the point of doing this. The kernel will always have to accept >>> requests from older versions of iproute2 (it can never be stricter) >>> because of ABI compatibility. So unless you can make a stronger >>> case for this; no not applying it. >>> >> >> iproute2 is often used as a reference model for features. Making >> iproute2 correct is the right thing to do regardless of whether what the >> kernel accepts. >> >> Current master branch is the first iproute2 to use the strict checking, >> and its first release with strict checking should have as many of these >> little one offs as possible fixed. > > With current iproute2-next and net-next I get: > > $ ip -6 route get 2001:db8:1::2 > Error: ipv6: Invalid flags for get route request. > > Are we going to patch the kernel to accept a flag it is not using or are > we going to patch iproute2 to not send it? > iproute2 (master should have the problem too) should not send the flag for IPv6. Stephen should apply Jakub's patch and I can merge branches.