From: Paolo Abeni <pabeni@redhat.com>
To: Mohsin Bashir <mohsin.bashr@gmail.com>,
Chris J Arges <carges@cloudflare.com>, Joe Damato <joe@dama.to>,
Jakub Kicinski <kuba@kernel.org>,
Andy Gospodarek <gospo@broadcom.com>,
Michael Chan <michael.chan@broadcom.com>,
Pavan Chebbi <pavan.chebbi@broadcom.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Stanislav Fomichev <sdf@fomichev.me>,
Shuah Khan <shuah@kernel.org>, Simon Horman <horms@kernel.org>,
Willem de Bruijn <willemb@google.com>, David Wei <dw@davidwei.uk>,
Daniel Zahka <daniel.zahka@gmail.com>,
Carolina Jubran <cjubran@nvidia.com>,
Dimitri Daskalakis <dimitri.daskalakis1@gmail.com>,
Nimrod Oren <noren@nvidia.com>, Gal Pressman <gal@nvidia.com>
Cc: Petr Machata <petrm@nvidia.com>, Cosmin Ratiu <cratiu@nvidia.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next v4 5/6] selftests: net: move common xdp.py functions into lib
Date: Tue, 17 Mar 2026 15:32:48 +0100 [thread overview]
Message-ID: <f5edbbfc-9d42-4911-9dac-e2597db7a2bc@redhat.com> (raw)
In-Reply-To: <f790d4e9-7f17-4878-860f-8d21c4c9c307@gmail.com>
On 3/17/26 7:48 AM, Mohsin Bashir wrote:
>> +def format_hex_bytes(value):
>> + """
>> + Helper function that converts an integer into a formatted hexadecimal byte string.
>> +
>> + Args:
>> + value: An integer representing the number to be converted.
>> +
>> + Returns:
>> + A string representing hexadecimal equivalent of value, with bytes separated by spaces.
>> + """
>> + hex_str = value.to_bytes(4, byteorder='little', signed=True)
>> + return ' '.join(f'{byte:02x}' for byte in hex_str)
>> +
>> +
>
> Since format_hex_bytes is not exported in __init__.py, Should it be
> prefixed with _ to indicate it is private?
I agree such cleanup would make sense.
/{
next prev parent reply other threads:[~2026-03-17 14:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 22:27 [PATCH net-next v4 0/6] bnxt_en: Add XDP RSS hash metadata support Chris J Arges
2026-03-13 22:27 ` [PATCH net-next v4 1/6] bnxt_en: use bnxt_xdp_buff for xdp context Chris J Arges
2026-03-14 0:00 ` Joe Damato
2026-03-13 22:27 ` [PATCH net-next v4 2/6] bnxt_en: Implement XDP RSS hash metadata extraction Chris J Arges
2026-03-13 22:27 ` [PATCH net-next v4 3/6] bnxt_en: Move bnxt_rss_ext_op into header Chris J Arges
2026-03-14 0:01 ` Joe Damato
2026-03-13 22:27 ` [PATCH net-next v4 4/6] bnxt_en: Implement XDP RSS hash metadata extraction for V3_CMP Chris J Arges
2026-03-14 0:03 ` Joe Damato
2026-03-13 22:27 ` [PATCH net-next v4 5/6] selftests: net: move common xdp.py functions into lib Chris J Arges
2026-03-17 6:48 ` Mohsin Bashir
2026-03-17 14:32 ` Paolo Abeni [this message]
2026-03-13 22:27 ` [PATCH net-next v4 6/6] selftests: drv-net: xdp: Add rss_hash metadata tests Chris J Arges
2026-03-17 9:49 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5edbbfc-9d42-4911-9dac-e2597db7a2bc@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=carges@cloudflare.com \
--cc=cjubran@nvidia.com \
--cc=cratiu@nvidia.com \
--cc=daniel.zahka@gmail.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dimitri.daskalakis1@gmail.com \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=gospo@broadcom.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=joe@dama.to \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=noren@nvidia.com \
--cc=pavan.chebbi@broadcom.com \
--cc=petrm@nvidia.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox