From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4F0EC433F5 for ; Tue, 9 Nov 2021 19:25:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B4F6961207 for ; Tue, 9 Nov 2021 19:25:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243185AbhKIT2X (ORCPT ); Tue, 9 Nov 2021 14:28:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243162AbhKIT2W (ORCPT ); Tue, 9 Nov 2021 14:28:22 -0500 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1234::107]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38743C061764; Tue, 9 Nov 2021 11:25:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=F98UNqntfHXxVudmAVesBMdsZFxqfEsY/m4RvE7VdZU=; b=oGv8zCSeFrB7Pt9axEhivrf9JS QaC9cTo2pCzQ3FiPTKdmBploWFeEMyTmxpIKDhxghOcV/IdOXsDU3jSicPUFvYEVd6kvk5hvx9IvL Cp+7sLQUobv1uVSWbdbzcs/CAHPTeItKYnFcbnev/Q+EAvUG4OTCWa4zTNvS4b1ED83O7yCjDkcUE fw+Zd1ViZaYkMMddC9OIZyQDmYhHAdyjl7xrMxXBVapaNHX6APLKlT6/AcXskH28/duF1DgGKOICJ rLRI17iN5ZmAeFmFW4TkK4AZtcJaTlfGxjb9D1fb9OvcwVA3Cn3sdTrRYdLZyYRiGpEI1h4oPXca3 YW+TvcvA==; Received: from [2601:1c0:6280:3f0::aa0b] by merlin.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkWkP-008ojx-No; Tue, 09 Nov 2021 19:25:34 +0000 Subject: Re: [PATCH net v9 3/3] net/8390: apne.c - add 100 Mbit support to apne.c driver To: Michael Schmitz , linux-m68k@vger.kernel.org, geert@linux-m68k.org Cc: alex@kazik.de, netdev@vger.kernel.org References: <20211109040242.11615-1-schmitzmic@gmail.com> <20211109040242.11615-4-schmitzmic@gmail.com> <3d4c9e98-f004-755c-2f30-45b951ede6a6@infradead.org> <1ed3a71a-e57b-0754-b719-36ac862413da@gmail.com> From: Randy Dunlap Message-ID: Date: Tue, 9 Nov 2021 11:25:30 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <1ed3a71a-e57b-0754-b719-36ac862413da@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 11/9/21 11:19 AM, Michael Schmitz wrote: > Hi Randy, > > On 09/11/21 18:44, Randy Dunlap wrote: >> On 11/8/21 8:55 PM, Michael Schmitz wrote: >>> Hi Randy, >>> >>> On 09/11/21 17:09, Randy Dunlap wrote: >>>> On 11/8/21 8:02 PM, Michael Schmitz wrote: >>>>> diff --git a/drivers/net/ethernet/8390/Kconfig >>>>> b/drivers/net/ethernet/8390/Kconfig >>>>> index a4130e643342..b22c3cf96560 100644 >>>>> --- a/drivers/net/ethernet/8390/Kconfig >>>>> +++ b/drivers/net/ethernet/8390/Kconfig >>>>> @@ -136,6 +136,8 @@ config NE2K_PCI >>>>>   config APNE >>>>>       tristate "PCMCIA NE2000 support" >>>>>       depends on AMIGA_PCMCIA >>>>> +    select PCCARD >>>>> +    select PCMCIA >>>>>       select CRC32 >>>> >>>> Hi, >>>> >>>> There are no other drivers that "select PCCARD" or >>>> "select PCMCIA" in the entire kernel tree. >>>> I don't see any good justification to allow it here. >>> >>> Amiga doesn't use anything from the core PCMCIA code, instead >>> providing its own basic PCMCIA support code. >>> >>> I had initially duplicated some of the cis tuple parser code, but >>> decided to use what's already there instead. >>> >>> I can drop these selects, and add instructions to manually select >>> these options in the Kconfig help section. Seemed a little error prone >>> to me. >> >> Just make it the same as other drivers in this respect, please. > > "depends on PCMCIA" is what I've seen for other drivers. That is not really appropriate for the APNE driver (8 bit cards work fine with just the support code from arch/m68k/amiga/pcmcia.c). > > Please confirm that "depends on PCMCIA" is what you want me to use? Hi Michael, I don't want to see this driver using 'select', so that probably only leaves "depends on". But if you or Geert tell me that I am bonkers, so be it. :) Thanks. -- ~Randy