From: Johannes Berg <johannes@sipsolutions.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netdev@vger.kernel.org
Subject: Re: [RFC] netlink: limit recursion depth in policy validation
Date: Fri, 26 Apr 2019 19:08:00 +0200 [thread overview]
Message-ID: <f630bfd637810c088ad1be782c5ce6f4cf1be8ef.camel@sipsolutions.net> (raw)
In-Reply-To: <20190426170649.5aa6b64464zmeeze@salvia>
On Fri, 2019-04-26 at 19:06 +0200, Pablo Neira Ayuso wrote:
>
> > This basically flattens the whole thing.
> >
> > Obviously, the walking may allocate some memory, and the last loop to
> > send it out isn't actually a loop like that because it's a netlink dump
> > with each entry being in a separate netlink message, but that's the gist
> > of it.
>
> I see, following this approach, I can just remove the duplicated code
> in my netlink description stuff by using the list of policy
> structures.
I wrote the code in a way that you can reuse it easily, check out the
patch :-) Generic netlink is one user added by the patch, but the actual
exposing code is with general attributes and general code that you can
easily call.
Meanwhile, I'm still writing a response to your other email, give me a
few minutes.
johannes
prev parent reply other threads:[~2019-04-26 17:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 21:24 [RFC] netlink: limit recursion depth in policy validation Johannes Berg
2019-04-26 16:57 ` Pablo Neira Ayuso
2019-04-26 17:03 ` Johannes Berg
2019-04-26 17:06 ` Pablo Neira Ayuso
2019-04-26 17:08 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f630bfd637810c088ad1be782c5ce6f4cf1be8ef.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox