From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6404C43217 for ; Tue, 19 Apr 2022 13:46:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245022AbiDSNsw (ORCPT ); Tue, 19 Apr 2022 09:48:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352894AbiDSNrJ (ORCPT ); Tue, 19 Apr 2022 09:47:09 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id CD283393F4 for ; Tue, 19 Apr 2022 06:41:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650375712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4adwg8hqyIITyJy5pTSFAx9A6BPYS26atLWx7A9LjPk=; b=HAfNlYPBJVU1n11d39HCAlDOdOwoQY2cFUuTOPPHjrBONyn2++PVLrGizvV4CL7yeBUcYM 2LPcWyirKwnY3VnqVO4rfgz3YamsXJ3UTGyCCWbiEwqYnL5AvqEcVYA58KyRR+2gGRTs19 5+ry1N/5B7KsYePsWizphCWJB1vdlpY= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-278-UTPLXTZQMSiEzVFA7JphQA-1; Tue, 19 Apr 2022 09:41:51 -0400 X-MC-Unique: UTPLXTZQMSiEzVFA7JphQA-1 Received: by mail-wm1-f69.google.com with SMTP id y11-20020a7bc18b000000b0038eac019fc0so1238189wmi.9 for ; Tue, 19 Apr 2022 06:41:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=4adwg8hqyIITyJy5pTSFAx9A6BPYS26atLWx7A9LjPk=; b=LLWs4qhC+smgvMkCrolDQb/hYJ/cKVSF1Ctijw/H2FQ+zbZ+RoQGxH6b9+nxUskw7L v8BtNPdfgy1vFqbZ7/mpfwrqm/OCcQuOMLAI3hNKt57Ic2JI4/1iC/1PdTMalONb0g5l rqjGizvqi2XtBo4n9gSCSjFQIkO5eORW/CjGYGLVFxaSx3xzJipCQj0y7ssv0a6dXbpr 7LRdA/U4QUtEgK8J2LAfAQiqzNiY/IzdmzegvNB6Go4pDlz5Xy/BttJdvA3ToxJ2rayI HdsNbH04Ojznc2R6x2Vk7t50px66trdzdKZgD85hIq6LCalI14mF2i6pUza82AUm44/v cTXQ== X-Gm-Message-State: AOAM531iieFAmIfEKTiJlwDvWBdWahvFDgpPqmZLoBtZCUZm1b1jCYDD N2mKdloWOR6tWCGJGlJp+MLW7UVhq5b3o0wrG4VFtnVXQU9KRWTZZwfMrxeosGAB+LP54fq6O0q osR6sYMWvTJo+C7SI X-Received: by 2002:a05:600c:1c1f:b0:38e:c425:5b1a with SMTP id j31-20020a05600c1c1f00b0038ec4255b1amr16136727wms.69.1650375706941; Tue, 19 Apr 2022 06:41:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyJvuZb+R54rr0s1wGva1v/Xk2FzPsygVQ3HcW3SsZOhzm7AK+wn4DeO9p0yN2bc4xhS4J72A== X-Received: by 2002:a05:600c:1c1f:b0:38e:c425:5b1a with SMTP id j31-20020a05600c1c1f00b0038ec4255b1amr16136712wms.69.1650375706746; Tue, 19 Apr 2022 06:41:46 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-96-237.dyn.eolo.it. [146.241.96.237]) by smtp.gmail.com with ESMTPSA id i27-20020a1c541b000000b003928e866d32sm9069716wmb.37.2022.04.19.06.41.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Apr 2022 06:41:46 -0700 (PDT) Message-ID: Subject: Re: [PATCH] net: ax88179: add proper error handling of usb read errors From: Paolo Abeni To: David Kahurani , netdev@vger.kernel.org Cc: syzbot+d3dbdf31fbe9d8f5f311@syzkaller.appspotmail.com, davem@davemloft.net, jgg@ziepe.ca, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, phil@philpotter.co.uk, syzkaller-bugs@googlegroups.com, arnd@arndb.de, dan.carpenter@oracle.com Date: Tue, 19 Apr 2022 15:41:45 +0200 In-Reply-To: <20220416074817.571160-1-k.kahurani@gmail.com> References: <20220416074817.571160-1-k.kahurani@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, 2022-04-16 at 10:48 +0300, David Kahurani wrote: > Reads that are lesser than the requested size lead to uninit-value bugs. > In this particular case a variable which was supposed to be initialized > after a read is left uninitialized after a partial read. > > Qualify such reads as errors and handle them correctly and while at it > convert the reader functions to return zero on success for easier error > handling. > > Fixes: e2ca90c276e1 ("ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to > gigabit ethernet adapter driver") In the next version, please additionally fix the above tag: it must use a single line, even if that means exceeding the 72 chars length limit. Thanks! Paolo