netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Mike Manning <mmanning@vyatta.att-mail.com>, netdev@vger.kernel.org
Cc: Robert Shearman <rshearma@vyatta.att-mail.com>
Subject: Re: [PATCH net-next v2 01/10] net: allow binding socket in a VRF when there's an unbound socket
Date: Tue, 2 Oct 2018 13:39:09 -0600	[thread overview]
Message-ID: <f6591922-07eb-2a33-747c-3ad118c52f68@gmail.com> (raw)
In-Reply-To: <20181001084320.32453-2-mmanning@vyatta.att-mail.com>

On 10/1/18 2:43 AM, Mike Manning wrote:
> There is no easy way currently for applications that want to receive
> packets in the default VRF to be isolated from packets arriving in
> VRFs, which makes using VRF-unaware applications in a VRF-aware system
> a potential security risk.

please drop that paragraph from the commit message. It is misleading and
wrong.

Without VRF I can start ssh bound to wildcard address and port 22
allowing connections across any interface in the box. If I do not want
that sestup, I have options: e.g., bind ssh to the management address or
install netfilter rules. The same applies with VRF as I mentioned in the
v1 review.

You not liking the options or wanting another option is a different
reason for the change than claiming the current options are a security risk.

  reply	other threads:[~2018-10-03  2:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-01  8:43 [PATCH net-next v2 00/10] vrf: allow simultaneous service instances in default and other VRFs Mike Manning
2018-10-01  8:43 ` [PATCH net-next v2 01/10] net: allow binding socket in a VRF when there's an unbound socket Mike Manning
2018-10-02 19:39   ` David Ahern [this message]
2018-10-01  8:43 ` [PATCH net-next v2 02/10] net: ensure unbound stream socket to be chosen when not in a VRF Mike Manning
2018-10-01  8:43 ` [PATCH net-next v2 03/10] net: ensure unbound datagram " Mike Manning
2018-10-01  8:43 ` [PATCH net-next v2 04/10] net: provide a sysctl raw_l3mdev_accept for raw socket lookup with VRFs Mike Manning
2018-10-02 19:39   ` David Ahern
2018-10-01  8:43 ` [PATCH net-next v2 05/10] net: fix raw socket lookup device bind matching " Mike Manning
2018-10-01  8:43 ` [PATCH net-next v2 06/10] net: IP[V6]_MULTICAST_IF constraint on unbound socket if VRFs present Mike Manning
2018-10-02 19:59   ` David Ahern
2018-10-01  8:43 ` [PATCH net-next v2 07/10] vrf: mark skb for multicast or link-local as enslaved to VRF Mike Manning
2018-10-01  8:43 ` [PATCH net-next v2 08/10] ipv6: allow ping to link-local address in VRF Mike Manning
2018-10-01  8:43 ` [PATCH net-next v2 09/10] ipv6: handling of multicast packets received " Mike Manning
2018-10-01  8:43 ` [PATCH net-next v2 10/10] ipv6: do not drop vrf udp multicast packets Mike Manning
2018-10-02 20:16 ` [PATCH net-next v2 00/10] vrf: allow simultaneous service instances in default and other VRFs David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f6591922-07eb-2a33-747c-3ad118c52f68@gmail.com \
    --to=dsahern@gmail.com \
    --cc=mmanning@vyatta.att-mail.com \
    --cc=netdev@vger.kernel.org \
    --cc=rshearma@vyatta.att-mail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).