From: David Ahern <dsahern@gmail.com>
To: ishaangandhi <ishaangandhi@gmail.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org, willemb@google.com,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v3] icmp: support rfc5837
Date: Fri, 19 Mar 2021 08:55:00 -0600 [thread overview]
Message-ID: <f65cb281-c6d5-d1c9-a90d-3281cdb75620@gmail.com> (raw)
In-Reply-To: <20210317221959.4410-1-ishaangandhi@gmail.com>
On 3/17/21 4:19 PM, ishaangandhi wrote:
> +void icmp_identify_arrival_interface(struct sk_buff *skb, struct net *net, int room,
> + char *icmph, int ip_version)
> +{
> + unsigned int ext_len, orig_len, word_aligned_orig_len, offset, extra_space_needed,
> + if_index, mtu = 0, name_len = 0, name_subobj_len = 0;
> + struct interface_ipv4_addr_sub_obj ip4_addr_subobj = {.addr = 0};
> + struct interface_ipv6_addr_sub_obj ip6_addr_subobj;
> + struct icmp_extobj_hdr *iio_hdr;
> + struct inet6_ifaddr ip6_ifaddr;
> + struct inet6_dev *dev6 = NULL;
> + struct icmp_ext_hdr *ext_hdr;
> + char *name = NULL, ctype;
> + struct net_device *dev;
> + void *subobj_offset;
> +
> + skb_linearize(skb);
> + if_index = inet_iif(skb);
inet_iif is an IPv4 helper; it should not be used for v6 skb's.
next prev parent reply other threads:[~2021-03-19 14:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 22:19 [PATCH v3] icmp: support rfc5837 ishaangandhi
2021-03-19 14:55 ` David Ahern [this message]
2021-03-19 16:11 ` Ishaan Gandhi
2021-03-19 23:54 ` David Ahern
2021-03-20 0:53 ` Willem de Bruijn
2021-03-20 4:24 ` David Ahern
2021-03-20 20:35 ` rfc5837 and rfc8335 David Ahern
2021-03-22 1:50 ` Ishaan Gandhi
[not found] ` <CAJByZJBNMqVDXjcOGCJHGcAv+sT4oEv1FD608TpA_e-J2a3L2w@mail.gmail.com>
[not found] ` <BL0PR05MB5316A2F5C2F1A727FA0190F3AE649@BL0PR05MB5316.namprd05.prod.outlook.com>
2021-03-25 3:19 ` David Ahern
2021-03-29 14:49 ` Ron Bonica
2021-03-29 19:39 ` Ron Bonica
2021-03-31 14:04 ` Willem de Bruijn
2021-03-31 17:56 ` Ron Bonica
2021-04-08 22:03 ` Ishaan Gandhi
2021-05-03 1:41 ` RESEND " Ishaan Gandhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f65cb281-c6d5-d1c9-a90d-3281cdb75620@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=ishaangandhi@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).