From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 262143A963C for ; Wed, 21 Jan 2026 08:18:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768983502; cv=none; b=TYKlgJurL6XEFK0dP6j/sac2ST+tS6lIUopW4jcN2o0E26taGp3UW8YQRgO6RVYfnHYJt+exr8zIhB2FYhbBoYV5PY54JaObbqC6e7IFafAaFagqi0zAFOK2gtT8cQTWZKt988P9PSWlVvMsdXb4TaKcCPVMRvctHHGdPoUcTYE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768983502; c=relaxed/simple; bh=U343qNv7qbWMJcdsCcBtAL2GBFHc2bv4QbKCqd3eQqI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FL2K1gPZg3bztp84ZIxRk3uADr2GMbjivlrJ8B+KGD/cayPzh0pTi2RTfDuIqS61/Lhb5C1Qzyrai+CijOqdExOBKhJcPkRcLm5PGepT6MDdJ1TXuCRUxgd/o1IZ0XNd25JBntnuLGq3jXeGef0yNmxGsKgNyZLL2m5/+QUmjU0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SqWCvrLo; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SqWCvrLo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768983500; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aLjuYxOngZSy7JCsu6Pfdx7HjhY/QhYRMKePJQYZ+kE=; b=SqWCvrLoFy5uwjN9vj2nFJQzqIa+4P8tXYB6qLu35xmVskSqNJSeNeCOLL+6ZdNrIrxppi /iPWmcuxsngzPKwJT7gpxjkW1uwucqvHfrN6MoHNrDzolgYkTj/QerAXzmfYhOgaQLmJzO EKFnuTRsnmxtmn3YThqryRF7qfuJKNg= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-665-218-VjNYMlmT1VsvIqeGiQ-1; Wed, 21 Jan 2026 03:18:16 -0500 X-MC-Unique: 218-VjNYMlmT1VsvIqeGiQ-1 X-Mimecast-MFC-AGG-ID: 218-VjNYMlmT1VsvIqeGiQ_1768983493 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B6F8E19560A5; Wed, 21 Jan 2026 08:18:12 +0000 (UTC) Received: from [10.44.32.187] (unknown [10.44.32.187]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E467F19560A2; Wed, 21 Jan 2026 08:18:03 +0000 (UTC) Message-ID: Date: Wed, 21 Jan 2026 09:18:02 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [net-next,v2,08/12] dpll: Enhance and consolidate reference counting logic To: Jakub Kicinski Cc: conor+dt@kernel.org, poros@redhat.com, anthony.l.nguyen@intel.com, linux-rdma@vger.kernel.org, tariqt@nvidia.com, robh@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, aleksander.lobakin@intel.com, mbloch@nvidia.com, jiri@resnulli.us, Prathosh.Satish@microchip.com, krzk+dt@kernel.org, saeedm@nvidia.com, devicetree@vger.kernel.org, davem@davemloft.net, pabeni@redhat.com, przemyslaw.kitszel@intel.com, arkadiusz.kubalewski@intel.com, jonathan.lemon@gmail.com, saravanak@kernel.org, aleksandr.loktionov@intel.com, mschmidt@redhat.com, edumazet@google.com, leon@kernel.org, vadim.fedorenko@linux.dev, grzegorz.nitka@intel.com, intel-wired-lan@lists.osuosl.org, richardcochran@gmail.com, andrew+netdev@lunn.ch References: <20260116184610.147591-9-ivecera@redhat.com> <20260121001650.1904392-2-kuba@kernel.org> Content-Language: en-US From: Ivan Vecera In-Reply-To: <20260121001650.1904392-2-kuba@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 On 1/21/26 1:16 AM, Jakub Kicinski wrote: > This is an AI-generated review of your patch. > > Dunno if there's a reason for having this fixed by a later patch, > if not let's fix. I'm sending the review mostly because of the > comments on patch 12. Will reorder these patches... Maybe it would be better to send patch 9 separately to net as this is the fix for the bug we found during development of this series. Ivan