From: Fernando Fernandez Mancera <fmancera@suse.de>
To: Ido Schimmel <idosch@nvidia.com>
Cc: netdev@vger.kernel.org, "Ricardo B. Marlière" <rbm@suse.com>,
"David S. Miller" <davem@davemloft.net>,
"David Ahern" <dsahern@kernel.org>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/10 net-next v3] ipv6: prepare headers for ipv6_stub removal
Date: Wed, 18 Mar 2026 11:43:40 +0100 [thread overview]
Message-ID: <f67f32ef-d619-4f61-9054-e6b6340129ad@suse.de> (raw)
In-Reply-To: <20260317201236.GA3581148@shredder>
On 3/17/26 9:12 PM, Ido Schimmel wrote:
> On Tue, Mar 17, 2026 at 03:01:00PM +0100, Fernando Fernandez Mancera wrote:
>> diff --git a/include/net/ndisc.h b/include/net/ndisc.h
>> index d38783a2ce57..6152401f29f1 100644
>> --- a/include/net/ndisc.h
>> +++ b/include/net/ndisc.h
>> @@ -69,6 +69,12 @@ struct prefix_info;
>>
>> extern struct neigh_table nd_tbl;
>>
>> +#if IS_ENABLED(CONFIG_IPV6)
>> +#define ipv6_get_nd_tbl() (&nd_tbl)
>> +#else
>> +#define ipv6_get_nd_tbl() NULL
>> +#endif
>
> What is the reason for converting code that is dependent on CONFIG_IPV6
> to use ipv6_get_nd_tbl()?
I did it mainly for consistency. If you think this isn't fine, I can
move it back to &nd_tbl directly.
Thanks,
Fernando.
next prev parent reply other threads:[~2026-03-18 10:43 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 14:00 [PATCH 00/10 net-next v3] Convert CONFIG_IPV6 to built-in and remove stubs Fernando Fernandez Mancera
2026-03-17 14:00 ` [PATCH 01/10 net-next v3] ipv6: convert CONFIG_IPV6 to built-in only and clean up Kconfigs Fernando Fernandez Mancera
2026-03-18 6:51 ` Krzysztof Kozlowski
2026-03-18 9:50 ` Ricardo B. Marlière
2026-03-18 10:14 ` Fernando Fernandez Mancera
2026-03-18 10:17 ` Krzysztof Kozlowski
2026-03-17 14:00 ` [PATCH 02/10 net-next v3] ipv6: replace IS_BUILTIN(CONFIG_IPV6) with IS_ENABLED(CONFIG_IPV6) Fernando Fernandez Mancera
2026-03-17 14:00 ` [PATCH 03/10 net-next v3] ipv6: remove dynamic ICMPv6 sender registration infrastructure Fernando Fernandez Mancera
2026-03-17 14:01 ` [PATCH 04/10 net-next v3] ipv6: prepare headers for ipv6_stub removal Fernando Fernandez Mancera
2026-03-17 20:12 ` Ido Schimmel
2026-03-18 10:43 ` Fernando Fernandez Mancera [this message]
2026-03-18 12:45 ` Ido Schimmel
2026-03-18 13:01 ` Fernando Fernandez Mancera
2026-03-17 14:01 ` [PATCH 05/10 net-next v3] drivers: net: drop ipv6_stub usage and use direct function calls Fernando Fernandez Mancera
2026-03-17 14:01 ` [PATCH 06/10 net-next v3] ipv4: " Fernando Fernandez Mancera
2026-03-17 14:01 ` [PATCH 07/10 net-next v3] net: convert remaining ipv6_stub users to " Fernando Fernandez Mancera
2026-03-17 14:01 ` [PATCH 08/10 net-next v3] bpf: remove ipv6_bpf_stub completely and use " Fernando Fernandez Mancera
2026-03-17 14:01 ` [PATCH 09/10 net-next v3] ipv6: remove ipv6_stub infrastructure completely Fernando Fernandez Mancera
2026-03-17 14:01 ` [PATCH 10/10 net-next v3] netfilter: remove nf_ipv6_ops and use direct function calls Fernando Fernandez Mancera
2026-03-17 20:17 ` Ido Schimmel
2026-03-18 12:18 ` Fernando Fernandez Mancera
2026-03-17 19:49 ` [PATCH 00/10 net-next v3] Convert CONFIG_IPV6 to built-in and remove stubs Jakub Kicinski
2026-03-18 10:19 ` Fernando Fernandez Mancera
2026-03-18 23:21 ` Jakub Kicinski
2026-03-19 0:48 ` Jakub Kicinski
2026-03-19 8:28 ` Fernando Fernandez Mancera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f67f32ef-d619-4f61-9054-e6b6340129ad@suse.de \
--to=fmancera@suse.de \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rbm@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox