From: Jason Wang <jasowang@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: mst@redhat.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, john.fastabend@gmail.com
Subject: Re: [PATCH net-next] ptr_ring: fix integer overflow
Date: Tue, 30 Jan 2018 14:56:11 +0800 [thread overview]
Message-ID: <f69970a7-f991-b038-5e9f-701cf6d8ec41@redhat.com> (raw)
In-Reply-To: <20180129.120124.892750865825553841.davem@davemloft.net>
On 2018年01月30日 01:01, David Miller wrote:
> From: Jason Wang <jasowang@redhat.com>
> Date: Thu, 25 Jan 2018 15:31:42 +0800
>
>> We try to allocate one more entry for lockless peeking. The adding
>> operation may overflow which causes zero to be passed to kmalloc().
>> In this case, it returns ZERO_SIZE_PTR without any notice by ptr
>> ring. Try to do producing or consuming on such ring will lead NULL
>> dereference. Fix this detect and fail early.
>>
>> Fixes: bcecb4bbf88a ("net: ptr_ring: otherwise safe empty checks can overrun array bounds")
>> Reported-by: syzbot+87678bcf753b44c39b67@syzkaller.appspotmail.com
>> Cc: John Fastabend <john.fastabend@gmail.com>
>> Signed-off-by: Jason Wang <jasowang@redhat.com>
> I'm dropping this because I am to understand that Michael Tsirkin's patch
> series covers this issue.
Yes.
>
> Let me know if I still need to apply this.
>
> Thanks.
No need for this.
Thanks
prev parent reply other threads:[~2018-01-30 6:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 7:31 [PATCH net-next] ptr_ring: fix integer overflow Jason Wang
2018-01-25 13:45 ` Michael S. Tsirkin
2018-01-25 14:17 ` Jason Wang
2018-01-25 17:31 ` Michael S. Tsirkin
2018-01-26 3:44 ` Jason Wang
2018-01-26 13:51 ` Michael S. Tsirkin
2018-01-29 17:01 ` David Miller
2018-01-30 6:56 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f69970a7-f991-b038-5e9f-701cf6d8ec41@redhat.com \
--to=jasowang@redhat.com \
--cc=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).