From: Paolo Abeni <pabeni@redhat.com>
To: "Boris Sukholitko" <boris.sukholitko@broadcom.com>,
netdev@vger.kernel.org, "Martin KaFai Lau" <martin.lau@linux.dev>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"John Fastabend" <john.fastabend@gmail.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Eduard Zingerman" <eddyz87@gmail.com>,
"Song Liu" <song@kernel.org>,
"Yonghong Song" <yonghong.song@linux.dev>,
"KP Singh" <kpsingh@kernel.org>,
"Stanislav Fomichev" <sdf@fomichev.me>,
"Hao Luo" <haoluo@google.com>, "Jiri Olsa" <jolsa@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Pravin B Shelar" <pshelar@ovn.org>,
"Jamal Hadi Salim" <jhs@mojatatu.com>,
"Cong Wang" <xiyou.wangcong@gmail.com>,
"Jiri Pirko" <jiri@resnulli.us>, "Shuah Khan" <shuah@kernel.org>,
"Willem de Bruijn" <willemb@google.com>,
"Pavel Begunkov" <asml.silence@gmail.com>,
"Mina Almasry" <almasrymina@google.com>,
"Lorenzo Bianconi" <lorenzo@kernel.org>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"David Howells" <dhowells@redhat.com>,
"Liang Chen" <liangchen.linux@gmail.com>,
"Alexander Lobakin" <aleksander.lobakin@intel.com>,
"Thomas Weißschuh" <linux@weissschuh.net>,
"Ido Schimmel" <idosch@idosch.org>
Cc: Ilya Lifshits <ilya.lifshits@broadcom.com>
Subject: Re: [PATCH net-next v3 1/3] tc: adjust network header after 2nd vlan push
Date: Thu, 22 Aug 2024 11:41:19 +0200 [thread overview]
Message-ID: <f6befca6-4f89-4d9c-b3eb-68e80da5c285@redhat.com> (raw)
In-Reply-To: <20240819110609.101250-2-boris.sukholitko@broadcom.com>
On 8/19/24 13:06, Boris Sukholitko wrote:
> diff --git a/net/sched/act_vlan.c b/net/sched/act_vlan.c
> index 22f4b1e8ade9..9e2dbde3cc29 100644
> --- a/net/sched/act_vlan.c
> +++ b/net/sched/act_vlan.c
> @@ -96,6 +96,7 @@ TC_INDIRECT_SCOPE int tcf_vlan_act(struct sk_buff *skb,
> if (skb_at_tc_ingress(skb))
> skb_pull_rcsum(skb, skb->mac_len);
>
> + skb_reset_mac_header(skb);
This should be:
skb_reset_mac_len(skb);
right?
I'm baffled by the fact that the self-tests looks still happy?!?
Thanks,
Paolo
next prev parent reply other threads:[~2024-08-22 9:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 11:06 [PATCH net-next v3 0/3] tc: adjust network header after 2nd vlan push Boris Sukholitko
2024-08-19 11:06 ` [PATCH net-next v3 1/3] " Boris Sukholitko
2024-08-22 9:41 ` Paolo Abeni [this message]
2024-08-22 10:04 ` Boris Sukholitko
2024-08-19 11:06 ` [PATCH net-next v3 2/3] selftests: tc_actions: test ingress " Boris Sukholitko
2024-08-19 11:06 ` [PATCH net-next v3 3/3] selftests: tc_actions: test egress " Boris Sukholitko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6befca6-4f89-4d9c-b3eb-68e80da5c285@redhat.com \
--to=pabeni@redhat.com \
--cc=aleksander.lobakin@intel.com \
--cc=almasrymina@google.com \
--cc=andrii@kernel.org \
--cc=asml.silence@gmail.com \
--cc=ast@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=boris.sukholitko@broadcom.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=eddyz87@gmail.com \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=idosch@idosch.org \
--cc=ilya.lifshits@broadcom.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=liangchen.linux@gmail.com \
--cc=linux@weissschuh.net \
--cc=lorenzo@kernel.org \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=willemb@google.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).