From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexei Starovoitov Subject: Re: [PATCH net 7/8] net/mlx5e: Count GSO packets correctly Date: Tue, 21 Mar 2017 07:40:43 -0700 Message-ID: References: <20170321135919.25018-1-saeedm@mellanox.com> <20170321135919.25018-8-saeedm@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Cc: , Or Gerlitz , Gal Pressman , To: Saeed Mahameed , "David S. Miller" Return-path: Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:50217 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757017AbdCUPC6 (ORCPT ); Tue, 21 Mar 2017 11:02:58 -0400 In-Reply-To: <20170321135919.25018-8-saeedm@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: On 3/21/17 6:59 AM, Saeed Mahameed wrote: > From: Gal Pressman > > TX packets statistics ('tx_packets' counter) used to count GSO packets > as one, even though it contains multiple segments. > This patch will increment the counter by the number of segments, and > align the driver with the behavior of other drivers in the stack. > > Note that no information is lost in this patch due to 'tx_tso_packets' > counter existence. > > Before, ethtool showed: > $ ethtool -S ens6 | egrep "tx_packets|tx_tso_packets" > tx_packets: 61340 > tx_tso_packets: 60954 > tx_packets_phy: 2451115 > > Now, we will see the more logical statistics: > $ ethtool -S ens6 | egrep "tx_packets|tx_tso_packets" > tx_packets: 2451115 > tx_tso_packets: 60954 > tx_packets_phy: 2451115 > > Fixes: e586b3b0baee ("net/mlx5: Ethernet Datapath files") > Signed-off-by: Gal Pressman > Cc: kernel-team@fb.com > Signed-off-by: Saeed Mahameed thank you for fixing! Acked-by: Alexei Starovoitov