From: Eric Dumazet <eric.dumazet@gmail.com>
To: Peter Oskolkov <posk@google.com>, Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Stfan Bader <stefan.bader@canonical.com>,
Florian Westphal <fw@strlen.de>
Subject: Re: [PATCH net] ip6: fix skb leak in ip6frag_expire_frag_queue()
Date: Fri, 3 May 2019 13:13:59 -0400 [thread overview]
Message-ID: <f6f20a1f-d86d-b735-e359-5ae7d2d8c546@gmail.com> (raw)
In-Reply-To: <CAPNVh5c88ZSAuhjdpf6_AULufZqjSkjWB7W8tguKzRTwYJbTWA@mail.gmail.com>
On 5/3/19 11:58 AM, Peter Oskolkov wrote:
> On Fri, May 3, 2019 at 8:52 AM Eric Dumazet <edumazet@google.com> wrote:
>>
>> On Fri, May 3, 2019 at 11:33 AM Peter Oskolkov <posk@google.com> wrote:
>>>
>>> This skb_get was introduced by commit 05c0b86b9696802fd0ce5676a92a63f1b455bdf3
>>> "ipv6: frags: rewrite ip6_expire_frag_queue()", and the rbtree patch
>>> is not in 4.4, where the bug is reported at.
>>> Shouldn't the "Fixes" tag also reference the original patch?
>>
>> No, this bug really fixes a memory leak.
>>
>> Fact that it also fixes the XFRM issue is secondary, since all your
>> patches are being backported in stable
>> trees anyway for other reasons.
>
> There are no plans to backport rbtree patches to 4.4 and earlier at
> the moment, afaik.
>
No problem, I mentioned to Stefan what needs to be done.
(removing the head skb, removing the skb_get())
prev parent reply other threads:[~2019-05-03 17:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 11:47 [PATCH net] ip6: fix skb leak in ip6frag_expire_frag_queue() Eric Dumazet
2019-05-03 14:55 ` Nicolas Dichtel
2019-05-03 14:56 ` Eric Dumazet
2019-05-03 15:33 ` Peter Oskolkov
2019-05-03 15:52 ` Eric Dumazet
2019-05-03 15:58 ` Peter Oskolkov
2019-05-03 17:13 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6f20a1f-d86d-b735-e359-5ae7d2d8c546@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=posk@google.com \
--cc=stefan.bader@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).