From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Cc: edumazet@google.com
Subject: Re: [PATCH RFC] tcp: Do not reload skb pointer after skb_gro_receive().
Date: Mon, 11 Jun 2018 19:59:37 -0700 [thread overview]
Message-ID: <f70f39b8-d3ab-132a-2447-3dd1c813e7b9@gmail.com> (raw)
In-Reply-To: <20180611.180013.526861738690091217.davem@davemloft.net>
On 06/11/2018 06:00 PM, David Miller wrote:
>
> This is not necessary. skb_gro_receive() will never change what
> 'head' points to.
>
> In it's original implementation (see commit 71d93b39e52e ("net: Add
> skb_gro_receive")), it did:
>
> ====================
> + *head = nskb;
> + nskb->next = p->next;
> + p->next = NULL;
> ====================
>
> This sequence was removed in commit 58025e46ea2d ("net: gro: remove
> obsolete code from skb_gro_receive()")
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
SGTM, thanks David !
Signed-off-by: Eric Dumazet <edumazet@google.com>
prev parent reply other threads:[~2018-06-12 2:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 1:00 [PATCH RFC] tcp: Do not reload skb pointer after skb_gro_receive() David Miller
2018-06-12 2:59 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f70f39b8-d3ab-132a-2447-3dd1c813e7b9@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).