From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH RFC] tcp: Do not reload skb pointer after skb_gro_receive(). Date: Mon, 11 Jun 2018 19:59:37 -0700 Message-ID: References: <20180611.180013.526861738690091217.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: edumazet@google.com To: David Miller , netdev@vger.kernel.org Return-path: Received: from mail-pl0-f65.google.com ([209.85.160.65]:45138 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935136AbeFLC7j (ORCPT ); Mon, 11 Jun 2018 22:59:39 -0400 Received: by mail-pl0-f65.google.com with SMTP id c23-v6so13483494plz.12 for ; Mon, 11 Jun 2018 19:59:39 -0700 (PDT) In-Reply-To: <20180611.180013.526861738690091217.davem@davemloft.net> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 06/11/2018 06:00 PM, David Miller wrote: > > This is not necessary. skb_gro_receive() will never change what > 'head' points to. > > In it's original implementation (see commit 71d93b39e52e ("net: Add > skb_gro_receive")), it did: > > ==================== > + *head = nskb; > + nskb->next = p->next; > + p->next = NULL; > ==================== > > This sequence was removed in commit 58025e46ea2d ("net: gro: remove > obsolete code from skb_gro_receive()") > > Signed-off-by: David S. Miller SGTM, thanks David ! Signed-off-by: Eric Dumazet