From: Eric Dumazet <eric.dumazet@gmail.com>
To: Qing Huang <qing.huang@oracle.com>,
Tariq Toukan <tariqt@mellanox.com>,
davem@davemloft.net, haakon.bugge@oracle.com,
yanjun.zhu@oracle.com
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] mlx4_core: allocate ICM memory in page size chunks
Date: Tue, 15 May 2018 12:08:01 -0700 [thread overview]
Message-ID: <f71278c2-a111-1bf6-2ff3-d9a8dd46bfbe@gmail.com> (raw)
In-Reply-To: <f4c5d8d3-1eea-8566-9921-a9dc48435f66@oracle.com>
On 05/15/2018 11:53 AM, Qing Huang wrote:
>
>> This is control path so it is less latency-sensitive.
>> Let's not produce unnecessary degradation here, please call kvzalloc so we maintain a similar behavior when contiguous memory is available, and a fallback for resiliency.
>
> No sure what exactly degradation is caused by vzalloc here. I think it's better to keep physically contiguous pages
> to other requests which really need them. Besides slow path/mem compacting can be really expensive.
>
Just use kvzalloc(), and you get the benefit of having contiguous memory if available,
without expensive compact phase.
This thing _automatically_ falls back to vmalloc(), thus your problem will be solved.
If you are not sure, trust others.
next prev parent reply other threads:[~2018-05-15 19:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 19:23 [PATCH V2] mlx4_core: allocate ICM memory in page size chunks Qing Huang
2018-05-13 9:00 ` Tariq Toukan
2018-05-14 16:41 ` Qing Huang
2018-05-15 9:19 ` Tariq Toukan
2018-05-15 18:53 ` Qing Huang
2018-05-15 19:08 ` Eric Dumazet [this message]
2018-05-15 19:45 ` Qing Huang
2018-05-16 7:04 ` Tariq Toukan
2018-05-16 10:10 ` Gi-Oh Kim
2018-05-17 18:39 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f71278c2-a111-1bf6-2ff3-d9a8dd46bfbe@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=haakon.bugge@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=qing.huang@oracle.com \
--cc=tariqt@mellanox.com \
--cc=yanjun.zhu@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).