From: Florian Fainelli <f.fainelli@gmail.com>
To: Tao Ren <taoren@fb.com>, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Vladimir Oltean <olteanv@gmail.com>,
Arun Parameswaran <arun.parameswaran@broadcom.com>,
Justin Chen <justinpopo6@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
openbmc@lists.ozlabs.org
Subject: Re: [PATCH net-next] net: phy: modify assignment to OR for dev_flags in phy_attach_direct
Date: Tue, 13 Aug 2019 12:54:36 -0700 [thread overview]
Message-ID: <f715d755-3f45-e90c-8913-7adec9f1dc9f@gmail.com> (raw)
In-Reply-To: <20190805185551.3140564-1-taoren@fb.com>
On 8/5/19 11:55 AM, Tao Ren wrote:
> Modify the assignment to OR when dealing with phydev->dev_flags in
> phy_attach_direct function, and this is to make sure dev_flags set in
> driver's probe callback won't be lost.
As Andrew pointed out already, this probably needs to be reworked, but
for now this looks reasonable:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
prev parent reply other threads:[~2019-08-13 19:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190805185551.3140564-1-taoren@fb.com>
2019-08-06 21:11 ` [PATCH net-next] net: phy: modify assignment to OR for dev_flags in phy_attach_direct Andrew Lunn
2019-08-13 19:54 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f715d755-3f45-e90c-8913-7adec9f1dc9f@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=arun.parameswaran@broadcom.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=justinpopo6@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=openbmc@lists.ozlabs.org \
--cc=taoren@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox