From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mg.ssi.bg (mg.ssi.bg [193.238.174.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30CF91BC2A; Sun, 21 Apr 2024 15:58:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.238.174.37 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713715104; cv=none; b=hdW3WHocENoQrgfiujqWb5XSuHlbDjbKOXLcuqJ+0ntmftHK0NKP7wM8XA9WDnzDxIQ+oD9nxwM55JFXU31UJyz/cDTRqTX8E5fPAFdCWG/4p0gnaV6yAlVSCK3AXrxNGmgHantA8qkje634HU/He36te0faHnt+Y8GnpL3Y9Xc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713715104; c=relaxed/simple; bh=O3g/dwNbPOlGeREP5DLztRfYyrPB9K8uTpS/h1FUspI=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=fzW6aHJJif4oxZoP8tof90u12W+L1oA7Q531NmKodcoU/+db1yRWVrUaAdWJEx305q1L5CcOOtd3hOMexX8E7vn4VRaZ5UnidwLcmXyi/axHI/B/2V6trbVlafn+qfSPJa/aWulUG6xHGc15QSIHlAC7GPHX+vZaFsINU1wSOas= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ssi.bg; spf=pass smtp.mailfrom=ssi.bg; dkim=pass (1024-bit key) header.d=ssi.bg header.i=@ssi.bg header.b=Q8KrmCo4; arc=none smtp.client-ip=193.238.174.37 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ssi.bg Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ssi.bg Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ssi.bg header.i=@ssi.bg header.b="Q8KrmCo4" Received: from mg.ssi.bg (localhost [127.0.0.1]) by mg.ssi.bg (Proxmox) with ESMTP id 708C122CE3; Sun, 21 Apr 2024 18:58:18 +0300 (EEST) Received: from ink.ssi.bg (ink.ssi.bg [193.238.174.40]) by mg.ssi.bg (Proxmox) with ESMTPS; Sun, 21 Apr 2024 18:58:17 +0300 (EEST) Received: from ja.ssi.bg (unknown [213.16.62.126]) by ink.ssi.bg (Postfix) with ESMTPSA id 8C3AB9003A6; Sun, 21 Apr 2024 18:58:13 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ssi.bg; s=ink; t=1713715093; bh=O3g/dwNbPOlGeREP5DLztRfYyrPB9K8uTpS/h1FUspI=; h=Date:From:To:cc:Subject:In-Reply-To:References; b=Q8KrmCo46WvXg/DCTE8uZcW0Aq6r5YH34HeegfnQhfFrYiPvEB973HpGOXl5uRAYx UFlzKg6UomPiBjDgm+W78HUPI1r585vxhkAHn+SZtJwZQVPOPAp+Ben1O54k2AlaGN xVG7fOODeJnQIryRCz+BrgXSkEhSLKkmcSUvzzoA= Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by ja.ssi.bg (8.17.1/8.17.1) with ESMTP id 43LFwBYu079854; Sun, 21 Apr 2024 18:58:11 +0300 Date: Sun, 21 Apr 2024 18:58:11 +0300 (EEST) From: Julian Anastasov To: Ismael Luceno cc: linux-kernel@vger.kernel.org, Firo Yang , Andreas Taschner , =?UTF-8?Q?Michal_Kube=C4=8Dek?= , Simon Horman , lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, coreteam@netfilter.org Subject: Re: [PATCH] ipvs: Fix checksumming on GSO of SCTP packets In-Reply-To: Message-ID: References: <20240418144434.16407-1-iluceno@suse.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Hello, On Sun, 21 Apr 2024, Ismael Luceno wrote: > On 21/Apr/2024 14:01, Julian Anastasov wrote: > > > I'm guessing what should be the Fixes line, may be?: > > > > Fixes: 90017accff61 ("sctp: Add GSO support") > > This seems like the right one. > > > because SCTP GSO was added after the IPVS code? Or the > > more recent commit d02f51cbcf12 which adds skb_is_gso_sctp ? > > That doesn't seem related at all. > > Do we need to check .gso_type in cases like this? Just skb_is_gso(skb) ? IMHO, this should work. Regards -- Julian Anastasov