From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com ([74.125.82.66]:53636 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751788AbeB0UKx (ORCPT ); Tue, 27 Feb 2018 15:10:53 -0500 Received: by mail-wm0-f66.google.com with SMTP id t74so909684wme.3 for ; Tue, 27 Feb 2018 12:10:52 -0800 (PST) Subject: Re: [PATCH net-next 02/11] ip6mr: Make mroute_sk rcu-based To: Yuval Mintz , netdev@vger.kernel.org Cc: mlxsw@mellanox.com, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org References: <1519757908-32863-1-git-send-email-yuvalm@mellanox.com> <1519757908-32863-3-git-send-email-yuvalm@mellanox.com> From: Nikolay Aleksandrov Message-ID: Date: Tue, 27 Feb 2018 22:10:49 +0200 MIME-Version: 1.0 In-Reply-To: <1519757908-32863-3-git-send-email-yuvalm@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On 27/02/18 20:58, Yuval Mintz wrote: > In ipmr the mr_table socket is handled under RCU. Introduce the same > for ip6mr. > > Signed-off-by: Yuval Mintz > --- > include/linux/mroute6.h | 6 +++--- > net/ipv6/ip6_output.c | 2 +- > net/ipv6/ip6mr.c | 45 +++++++++++++++++++++++++++------------------ > 3 files changed, 31 insertions(+), 22 deletions(-) LGTM, though do we need the write_lock when changing mroute6_sk after RCUfying it ? In any case that can be resolved later, Acked-by: Nikolay Aleksandrov