From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14A6FC282C8 for ; Mon, 28 Jan 2019 16:51:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CD17C21741 for ; Mon, 28 Jan 2019 16:51:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="uIMhWT5g" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388679AbfA1Qvr (ORCPT ); Mon, 28 Jan 2019 11:51:47 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:39221 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388526AbfA1Qvp (ORCPT ); Mon, 28 Jan 2019 11:51:45 -0500 Received: by mail-pf1-f196.google.com with SMTP id r136so8251596pfc.6 for ; Mon, 28 Jan 2019 08:51:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=wdqCWWQP01hQ1wXizFkZ+fyO/BbDmqsfJnCuZvtnGBk=; b=uIMhWT5g4k+KFbL/ejI85ProCNph7OJW4F5fqWgdhjlBbnzT+Lvztv+5pE/Hi0ueUz TGfY1tdUXNrxZ2++6ygTiS4egvyVx+SbENOkyzBNU+wmG9Me671rI9PcZZD3jCLm5PjL QgwiR5309pb4LybKgDwok7aCvOEsdMoY0t7yUA2ct7jdl2KJ4sxZo8/Wxkj7gxYjpOoM mPKCWf/NIt8lW6CHhh46MAd0gqI06AAjasBwQwGw7q8RBa/0YGYHq69xIrMyVkOQPMNd R3p7GDg2gMsWHkCqiQ3wSt2vljTATEheVoh3dPu9RdUSn3+Ak3Crw3Cl2EsVT5IjoqSq tZ/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wdqCWWQP01hQ1wXizFkZ+fyO/BbDmqsfJnCuZvtnGBk=; b=HgJbUr4euJxj8lpUTHueyf4Zook814vgCa4nYwkcxSfcm8gps+TI7KnNiCWwPOngU4 sE7YOSoFyhQmlRgR4/Ua99WldiFsD7ReFGhRC642sBAvhoyXgwg0aiWJ8b7ANeucm3tG IDDJ8/6ZP9TjPIO0cYUrLF4c9rOluqNhneVlSKLUgiMoTktF524psRC7MNLmGF/0uYnm 9z4UxQwlWNIK4NScf7XKroaZKNQ973F1lfCJ65rBJI2v/C5zt1CRPM0daTuX3HrlH+69 Bk1VvFDv2TRj6GiDD6IegKBm8Sfw30cBJ7ty47CZI9toE2AzaUCTSoh0Lrr2ypVGwQ3F ygTQ== X-Gm-Message-State: AJcUukflZsfHMCReKuR47S6W+l+X66h8GjZy4vW4JHSENpLjbgJhtzng OP532IaAe6pcNfFsXSJP7/09OrSA X-Google-Smtp-Source: ALg8bN5gCJ3b/C0YhIjBEZevlgLK7TinVegdWVHSx1QDhgVSZm6tZkxrP9zoKZ7VTVNKO/Cb1cq0jw== X-Received: by 2002:a63:6984:: with SMTP id e126mr20791704pgc.143.1548694304891; Mon, 28 Jan 2019 08:51:44 -0800 (PST) Received: from ?IPv6:2601:282:800:fd80:6cf4:7f15:5073:c792? ([2601:282:800:fd80:6cf4:7f15:5073:c792]) by smtp.googlemail.com with ESMTPSA id v15sm40968049pfn.94.2019.01.28.08.51.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Jan 2019 08:51:44 -0800 (PST) Subject: Re: [PATCH iproute2-next 2/2] tc: replace left side comparison To: Stephen Hemminger , netdev@vger.kernel.org References: <20190124203014.7450-1-stephen@networkplumber.org> <20190124203014.7450-2-stephen@networkplumber.org> From: David Ahern Message-ID: Date: Mon, 28 Jan 2019 09:51:42 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190124203014.7450-2-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/24/19 1:30 PM, Stephen Hemminger wrote: > The kernel (and iproute2) don't use the if (NULL == x) style > and instead prefer if (!x) > > Signed-off-by: Stephen Hemminger > --- > tc/m_action.c | 2 +- > tc/m_ipt.c | 3 +-- > tc/m_xt_old.c | 3 +-- > tc/tc_util.c | 2 +- > 4 files changed, 4 insertions(+), 6 deletions(-) > applied to iproute2-next. Thanks