From: Jacob Keller <jacob.e.keller@intel.com>
To: Heiner Kallweit <hkallweit1@gmail.com>,
Realtek linux nic maintainers <nic_swsd@realtek.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Simon Horman <horms@kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] r8169: switch away from deprecated pcim_iomap_table
Date: Thu, 13 Mar 2025 14:22:24 -0700 [thread overview]
Message-ID: <f79bb045-1c2a-4a2e-8ed2-ff4ff4f9c814@intel.com> (raw)
In-Reply-To: <a36b4cf3-c792-40fa-8164-5dc9d5f14dd0@gmail.com>
On 3/12/2025 12:21 PM, Heiner Kallweit wrote:
> Avoid using deprecated pcim_iomap_table by switching to
> pcim_iomap_region.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> drivers/net/ethernet/realtek/r8169_main.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
> index b18daeeda..53e541ddb 100644
> --- a/drivers/net/ethernet/realtek/r8169_main.c
> +++ b/drivers/net/ethernet/realtek/r8169_main.c
> @@ -5447,11 +5447,10 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
> if (region < 0)
> return dev_err_probe(&pdev->dev, -ENODEV, "no MMIO resource found\n");
>
> - rc = pcim_iomap_regions(pdev, BIT(region), KBUILD_MODNAME);
> - if (rc < 0)
> - return dev_err_probe(&pdev->dev, rc, "cannot remap MMIO, aborting\n");
> -
> - tp->mmio_addr = pcim_iomap_table(pdev)[region];
> + tp->mmio_addr = pcim_iomap_region(pdev, region, KBUILD_MODNAME);
> + if (IS_ERR(tp->mmio_addr))
> + return dev_err_probe(&pdev->dev, PTR_ERR(tp->mmio_addr),
> + "cannot remap MMIO, aborting\n");
>
> txconfig = RTL_R32(tp, TxConfig);
> if (txconfig == ~0U)
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
next prev parent reply other threads:[~2025-03-13 21:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 19:21 [PATCH net-next] r8169: switch away from deprecated pcim_iomap_table Heiner Kallweit
2025-03-13 21:22 ` Jacob Keller [this message]
2025-03-18 19:49 ` Simon Horman
2025-03-19 18:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f79bb045-1c2a-4a2e-8ed2-ff4ff4f9c814@intel.com \
--to=jacob.e.keller@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).