From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AFBEC433DB for ; Thu, 21 Jan 2021 05:47:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5277623884 for ; Thu, 21 Jan 2021 05:47:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728044AbhAUFqx (ORCPT ); Thu, 21 Jan 2021 00:46:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728672AbhAUDoE (ORCPT ); Wed, 20 Jan 2021 22:44:04 -0500 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBCE3C0617A2 for ; Wed, 20 Jan 2021 19:40:58 -0800 (PST) Received: by mail-pj1-x102f.google.com with SMTP id x20so732556pjh.3 for ; Wed, 20 Jan 2021 19:40:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=qAyoR5PX7yRHGQTJVioS8UlmuBJqcri8hRFmtF+ARUA=; b=tkRylR8DeJ8KFiycKXU3oZ8OOeQE+JPXboLYMLRTPp4KSwy/RHy8djmMRtVvYJgh5R POtGQ56cw8C4UMvD5fhtfihuZdu9X7fpIeI0p29DzrhTxqCxMVUD7TP0an3mj5vvXnlH XhC4LxboiuMFFTJLtw1YDUkCOdIb56eOg4TbXBJ5039CNa0El2qkaknmEiYrVXjxbFGs kKtBdaswi8dZ27PQiKxXXU7sMVmTdItgCFgDcTkyz1AVDCbUlZenheloYxeT/lJPm11N EWFdfNNzbDl9ctaM+etqETDUvhOEIRB/cEBlarviIxvohFjkhW3z4Wdcbl/m9KMgDLdQ NaBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qAyoR5PX7yRHGQTJVioS8UlmuBJqcri8hRFmtF+ARUA=; b=qIgNRCt49dcKC21TCLD0A0epZukO9vCKa6pPAe82O0kNDkS5WdPmQGxoZGzDzcBsZ+ /Q6+HQKHcVTRxg6/WK0Lb6rJYUP4LwXdF1SZXHG9ubkXojiegp6F9qPt+qnkxdXxFPFH LpIl6jK6wkZhNHFCkRPzwqQYGXNoEjnEOEjZtBDxFtKZsL1Zxg9yakmuhm2+TBj+YUcc fWFK1G6BiBOr5oTFcpG7OqXQ6wmFt1JG7VFttTJFms9xZp/RHEbK5vTz3rekVBds/SDb 4/OrNsWNjV8lpnLDz4U/uQG4tkI6gUrkkBYT9dv4TDD9o1VSxU3EnRspmFZgFUg9V+PT hiuQ== X-Gm-Message-State: AOAM532jPRjatAsqshWEUJ7HQBQbNnXbnWilSlr6LCp75VpX2p2aDX4l 3/RFBJ+3D2FZoajWimRS+u4= X-Google-Smtp-Source: ABdhPJxr3k7YpAZzlx9mgSmLt+mjaMLe8QoAghUJ2qTCsfwrWi8whnntFQxBxtdr6iv+MC4AOTEdeg== X-Received: by 2002:a17:902:e74d:b029:df:c991:8c4f with SMTP id p13-20020a170902e74db02900dfc9918c4fmr3250185plf.52.1611200458318; Wed, 20 Jan 2021 19:40:58 -0800 (PST) Received: from [10.230.29.30] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id c5sm2461774pgd.68.2021.01.20.19.40.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Jan 2021 19:40:57 -0800 (PST) Subject: Re: [PATCH v5 net-next 04/10] net: mscc: ocelot: reapply bridge forwarding mask on bonding join/leave To: Vladimir Oltean , "David S . Miller" , Jakub Kicinski , netdev@vger.kernel.org Cc: Andrew Lunn , Vivien Didelot , Richard Cochran , Claudiu Manoil , Alexandru Marginean , Alexandre Belloni , Xiaoliang Yang , Hongbo Wang , Vladimir Oltean , Po Liu , Yangbo Lu , Maxim Kochetkov , Eldar Gasanov , Andrey L , Tobias Waldekranz , UNGLinuxDriver@microchip.com References: <20210121023616.1696021-1-olteanv@gmail.com> <20210121023616.1696021-5-olteanv@gmail.com> From: Florian Fainelli Message-ID: Date: Wed, 20 Jan 2021 19:40:54 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210121023616.1696021-5-olteanv@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/20/2021 6:36 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > Applying the bridge forwarding mask currently is done only on the STP > state changes for any port. But it depends on both STP state changes, > and bonding interface state changes. Export the bit that recalculates > the forwarding mask so that it could be reused, and call it when a port > starts and stops offloading a bonding interface. > > Now that the logic is split into a separate function, we can rename "p" > into "port", since the "port" variable was already taken in > ocelot_bridge_stp_state_set. Also, we can rename "i" into "lag", to make > it more clear what is it that we're iterating through. > > Signed-off-by: Vladimir Oltean > Reviewed-by: Alexandre Belloni Reviewed-by: Florian Fainelli -- Florian