From: Richard Cochran <richardcochran@gmail.com>
To: <netdev@vger.kernel.org>
Cc: linux-kernel@vger.kernel.org, "Amir Vadai" <amirv@mellanox.com>,
"Ariel Elior" <ariel.elior@qlogic.com>,
"Arnd Bergmann" <arnd@linaro.org>,
"Baolin Wang" <baolin.wang@linaro.org>,
"Ben Hutchings" <ben@decadent.org.uk>,
"Bruce Allan" <bruce.w.allan@intel.com>,
"Carolyn Wyborny" <carolyn.wyborny@intel.com>,
"Chris Metcalf" <cmetcalf@ezchip.com>,
"David Miller" <davem@davemloft.net>,
"Frank Li" <Frank.Li@freescale.com>,
"Giuseppe Cavallaro" <peppe.cavallaro@st.com>,
"Jeff Kirsher" <jeffrey.t.kirsher@intel.com>,
"John Stultz" <john.stultz@linaro.org>,
"Luwei Zhou" <b45643@freescale.com>,
"Matthew Vick" <matthew.vick@intel.com>,
"Michael Chan" <mchan@broadcom.com>,
"Prashant Sreedharan" <prashant@broadcom.com>,
"Shradha Shah" <sshah@solarflare.com>,
"Solarflare linux maintainers" <linux-net-drivers@solarflare.com>,
"Sonic Zhang" <sonic.zhang@analog.com>
Subject: [RFC net-next 22/22] ptp: remove 32 bit get/set methods.
Date: Sat, 21 Mar 2015 21:59:52 +0100 [thread overview]
Message-ID: <f7bea007b66111ed84d335bd608ec6ac9834f905.1426970294.git.richardcochran@gmail.com> (raw)
In-Reply-To: <cover.1426970294.git.richardcochran@gmail.com>
All of the PHC drivers have been converted to the new methods. This patch
converts the three remaining callers within the core code and removes the
older methods for good. As a result, the core PHC code is ready for the
year 2038. However, some of the PHC drivers are not quite ready yet.
Signed-off-by: Richard Cochran <richardcochran@gmail.com>
---
drivers/ptp/ptp_chardev.c | 8 +-------
drivers/ptp/ptp_clock.c | 12 ++++++++++--
include/linux/ptp_clock_kernel.h | 8 --------
3 files changed, 11 insertions(+), 17 deletions(-)
diff --git a/drivers/ptp/ptp_chardev.c b/drivers/ptp/ptp_chardev.c
index 95bcf15..da7bae9 100644
--- a/drivers/ptp/ptp_chardev.c
+++ b/drivers/ptp/ptp_chardev.c
@@ -125,7 +125,6 @@ long ptp_ioctl(struct posix_clock *pc, unsigned int cmd, unsigned long arg)
struct ptp_clock_info *ops = ptp->info;
struct ptp_clock_time *pct;
struct timespec64 ts;
- struct timespec t2;
int enable, err = 0;
unsigned int i, pin_index;
@@ -202,12 +201,7 @@ long ptp_ioctl(struct posix_clock *pc, unsigned int cmd, unsigned long arg)
pct->sec = ts.tv_sec;
pct->nsec = ts.tv_nsec;
pct++;
- if (ptp->info->gettime64) {
- ptp->info->gettime64(ptp->info, &ts);
- } else {
- ptp->info->gettime(ptp->info, &t2);
- ts = timespec_to_timespec64(t2);
- }
+ ptp->info->gettime64(ptp->info, &ts);
pct->sec = ts.tv_sec;
pct->nsec = ts.tv_nsec;
pct++;
diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c
index 296b0ec..2665360 100644
--- a/drivers/ptp/ptp_clock.c
+++ b/drivers/ptp/ptp_clock.c
@@ -107,13 +107,21 @@ static int ptp_clock_getres(struct posix_clock *pc, struct timespec *tp)
static int ptp_clock_settime(struct posix_clock *pc, const struct timespec *tp)
{
struct ptp_clock *ptp = container_of(pc, struct ptp_clock, clock);
- return ptp->info->settime(ptp->info, tp);
+ struct timespec64 ts = timespec_to_timespec64(*tp);
+
+ return ptp->info->settime64(ptp->info, &ts);
}
static int ptp_clock_gettime(struct posix_clock *pc, struct timespec *tp)
{
struct ptp_clock *ptp = container_of(pc, struct ptp_clock, clock);
- return ptp->info->gettime(ptp->info, tp);
+ struct timespec64 ts;
+ int err;
+
+ err = ptp->info->gettime64(ptp->info, &ts);
+ if (!err)
+ *tp = timespec64_to_timespec(ts);
+ return err;
}
static int ptp_clock_adjtime(struct posix_clock *pc, struct timex *tx)
diff --git a/include/linux/ptp_clock_kernel.h b/include/linux/ptp_clock_kernel.h
index 7d6f8e6..b8b7306 100644
--- a/include/linux/ptp_clock_kernel.h
+++ b/include/linux/ptp_clock_kernel.h
@@ -64,12 +64,6 @@ struct ptp_clock_request {
* @adjtime: Shifts the time of the hardware clock.
* parameter delta: Desired change in nanoseconds.
*
- * @gettime: Reads the current time from the hardware clock. (deprecated)
- * parameter ts: Holds the result.
- *
- * @settime: Set the current time on the hardware clock. (deprecated)
- * parameter ts: Time value to set.
- *
* @gettime64: Reads the current time from the hardware clock.
* parameter ts: Holds the result.
*
@@ -110,8 +104,6 @@ struct ptp_clock_info {
struct ptp_pin_desc *pin_config;
int (*adjfreq)(struct ptp_clock_info *ptp, s32 delta);
int (*adjtime)(struct ptp_clock_info *ptp, s64 delta);
- int (*gettime)(struct ptp_clock_info *ptp, struct timespec *ts);
- int (*settime)(struct ptp_clock_info *ptp, const struct timespec *ts);
int (*gettime64)(struct ptp_clock_info *ptp, struct timespec64 *ts);
int (*settime64)(struct ptp_clock_info *p, const struct timespec64 *ts);
int (*enable)(struct ptp_clock_info *ptp,
--
1.7.10.4
next prev parent reply other threads:[~2015-03-21 20:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-21 20:59 [RFC net-next 00/22] ptp: get ready for 2038 Richard Cochran
2015-03-21 20:59 ` [RFC net-next 01/22] ptp: introduce get/set time methods with explicit 64 bit seconds Richard Cochran
2015-03-21 20:59 ` [RFC net-next 02/22] ptp: use the 64 bit gettime method for the SYS_OFFSET ioctl Richard Cochran
2015-03-21 20:59 ` [RFC net-next 03/22] ptp: blackfin: convert to the 64 bit get/set time methods Richard Cochran
2015-03-21 20:59 ` [RFC net-next 04/22] ptp: xgbe: " Richard Cochran
2015-03-21 20:59 ` [RFC net-next 05/22] ptp: bnx2x: " Richard Cochran
2015-03-21 20:59 ` [RFC net-next 06/22] ptp: tg3: " Richard Cochran
2015-03-21 20:59 ` [RFC net-next 07/22] ptp: fec: " Richard Cochran
2015-03-21 20:59 ` [RFC net-next 08/22] ptp: gianfar: " Richard Cochran
2015-03-21 20:59 ` [RFC net-next 09/22] ptp: e1000e: " Richard Cochran
2015-03-21 20:59 ` [RFC net-next 10/22] ptp: fm10k: " Richard Cochran
2015-03-21 20:59 ` [RFC net-next 11/22] ptp: i40e: " Richard Cochran
2015-03-21 20:59 ` [RFC net-next 12/22] ptp: igb: " Richard Cochran
2015-03-21 20:59 ` [RFC net-next 13/22] ptp: ixgbe: " Richard Cochran
2015-03-21 20:59 ` [RFC net-next 14/22] ptp: mlx4: " Richard Cochran
2015-03-21 20:59 ` [RFC net-next 15/22] ptp: sfc: " Richard Cochran
2015-03-21 20:59 ` [RFC net-next 16/22] ptp: stmmac: " Richard Cochran
2015-03-21 20:59 ` [RFC net-next 17/22] ptp: cpts: " Richard Cochran
2015-03-21 20:59 ` [RFC net-next 18/22] ptp: tilegx: " Richard Cochran
2015-03-21 20:59 ` [RFC net-next 19/22] ptp: dp83640: " Richard Cochran
2015-03-21 20:59 ` [RFC net-next 20/22] ptp: ixp46x: " Richard Cochran
2015-03-21 20:59 ` [RFC net-next 21/22] ptp: pch: " Richard Cochran
2015-03-21 20:59 ` Richard Cochran [this message]
2015-03-21 21:19 ` [RFC net-next 22/22] ptp: remove 32 bit get/set methods Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7bea007b66111ed84d335bd608ec6ac9834f905.1426970294.git.richardcochran@gmail.com \
--to=richardcochran@gmail.com \
--cc=Frank.Li@freescale.com \
--cc=amirv@mellanox.com \
--cc=ariel.elior@qlogic.com \
--cc=arnd@linaro.org \
--cc=b45643@freescale.com \
--cc=baolin.wang@linaro.org \
--cc=ben@decadent.org.uk \
--cc=bruce.w.allan@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=cmetcalf@ezchip.com \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net-drivers@solarflare.com \
--cc=matthew.vick@intel.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=prashant@broadcom.com \
--cc=sonic.zhang@analog.com \
--cc=sshah@solarflare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).