From: David Ahern <dsahern@kernel.org>
To: Eric Dumazet <eric.dumazet@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: netdev <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Coco Li <lixiaoyan@google.com>,
Alexander Duyck <alexanderduyck@fb.com>
Subject: Re: [PATCH v2 net-next 07/14] ipv6: add GRO_IPV6_MAX_SIZE
Date: Thu, 3 Mar 2022 21:37:17 -0700 [thread overview]
Message-ID: <f7c14a37-3404-2ad0-bb71-2446b52c572d@kernel.org> (raw)
In-Reply-To: <20220303181607.1094358-8-eric.dumazet@gmail.com>
On 3/3/22 11:16 AM, Eric Dumazet wrote:
> From: Coco Li <lixiaoyan@google.com>
>
> Enable GRO to have IPv6 specific limit for max packet size.
>
> This patch introduces new dev->gro_ipv6_max_size
> that is modifiable through ip link.
>
> ip link set dev eth0 gro_ipv6_max_size 185000
>
> Note that this value is only considered if bigger than
> gro_max_size, and for non encapsulated TCP/ipv6 packets.
>
What is the point of a max size for the Rx path that is per ingress
device? If the stack understands the larger packets then the ingress
device limits should not matter. (yes, I realize the existing code has
it this way, so I guess this is a historical question)
next prev parent reply other threads:[~2022-03-04 4:37 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 18:15 [PATCH v2 net-next 00/14] tcp: BIG TCP implementation Eric Dumazet
2022-03-03 18:15 ` [PATCH v2 net-next 01/14] net: add netdev->tso_ipv6_max_size attribute Eric Dumazet
2022-03-03 18:15 ` [PATCH v2 net-next 02/14] ipv6: add dev->gso_ipv6_max_size Eric Dumazet
2022-03-03 18:15 ` [PATCH v2 net-next 03/14] tcp_cubic: make hystart_ack_delay() aware of BIG TCP Eric Dumazet
2022-03-03 18:15 ` [PATCH v2 net-next 04/14] ipv6: add struct hop_jumbo_hdr definition Eric Dumazet
2022-03-04 19:26 ` Alexander H Duyck
2022-03-04 19:28 ` Eric Dumazet
2022-03-03 18:15 ` [PATCH v2 net-next 05/14] ipv6/gso: remove temporary HBH/jumbo header Eric Dumazet
2022-03-03 18:15 ` [PATCH v2 net-next 06/14] ipv6/gro: insert " Eric Dumazet
2022-03-03 18:16 ` [PATCH v2 net-next 07/14] ipv6: add GRO_IPV6_MAX_SIZE Eric Dumazet
2022-03-04 4:37 ` David Ahern [this message]
2022-03-04 17:16 ` Eric Dumazet
2022-03-03 18:16 ` [PATCH v2 net-next 08/14] ipv6: Add hop-by-hop header to jumbograms in ip6_output Eric Dumazet
2022-03-04 4:33 ` David Ahern
2022-03-04 15:48 ` Alexander H Duyck
2022-03-04 17:09 ` Eric Dumazet
2022-03-04 19:00 ` Alexander H Duyck
2022-03-04 19:13 ` Eric Dumazet
2022-03-05 16:53 ` David Ahern
2022-03-04 17:47 ` Eric Dumazet
2022-03-05 16:46 ` David Ahern
2022-03-05 18:08 ` Eric Dumazet
2022-03-05 19:06 ` David Ahern
2022-03-05 16:55 ` David Ahern
2022-03-03 18:16 ` [PATCH v2 net-next 09/14] net: loopback: enable BIG TCP packets Eric Dumazet
2022-03-03 18:16 ` [PATCH v2 net-next 10/14] bonding: update dev->tso_ipv6_max_size Eric Dumazet
2022-03-03 18:16 ` [PATCH v2 net-next 11/14] macvlan: enable BIG TCP Packets Eric Dumazet
2022-03-03 18:16 ` [PATCH v2 net-next 12/14] ipvlan: " Eric Dumazet
2022-03-03 18:16 ` [PATCH v2 net-next 13/14] mlx4: support BIG TCP packets Eric Dumazet
2022-03-08 16:03 ` Tariq Toukan
2022-03-03 18:16 ` [PATCH v2 net-next 14/14] mlx5: " Eric Dumazet
2022-03-04 4:42 ` David Ahern
2022-03-04 17:14 ` Eric Dumazet
2022-03-05 16:36 ` David Ahern
2022-03-05 17:57 ` Eric Dumazet
2022-03-08 16:02 ` Tariq Toukan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7c14a37-3404-2ad0-bb71-2446b52c572d@kernel.org \
--to=dsahern@kernel.org \
--cc=alexanderduyck@fb.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=lixiaoyan@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).