From: Jia-Ju Bai <baijiaju1990@gmail.com>
To: michael.chan@broadcom.com, davem@davemloft.net
Cc: netdev@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [BUG] net: broadcom: b44: Possible sleep-in-atomic-context bugs in b44_chip_reset()
Date: Sat, 15 Sep 2018 16:44:42 +0800 [thread overview]
Message-ID: <f7c5e6bf-867b-496b-c3e0-ce5766a33d26@gmail.com> (raw)
The driver may sleep with holding a spinlock.
The function call paths (from bottom to top) in Linux-4.17 are:
[FUNC] msleep
drivers/ssb/driver_pcicore.c, 671:
msleep in ssb_pcie_mdio_write
drivers/ssb/driver_pcicore.c, 446:
ssb_pcie_mdio_write in ssb_pcicore_serdes_workaround
drivers/ssb/driver_pcicore.c, 508:
ssb_pcicore_serdes_workaround in ssb_pcicore_pcie_setup_workarounds
drivers/ssb/driver_pcicore.c, 729:
ssb_pcicore_pcie_setup_workarounds in ssb_pcicore_dev_irqvecs_enable
drivers/net/ethernet/broadcom/b44.c, 1289:
ssb_pcicore_dev_irqvecs_enable in b44_chip_reset
drivers/net/ethernet/broadcom/b44.c, 1363:
b44_chip_reset in b44_halt
drivers/net/ethernet/broadcom/b44.c, 2498:
b44_halt in b44_suspend
drivers/net/ethernet/broadcom/b44.c, 2496:
spin_lock_irq in b44_suspend
[FUNC] msleep
drivers/ssb/driver_pcicore.c, 671:
msleep in ssb_pcie_mdio_write
drivers/ssb/driver_pcicore.c, 446:
ssb_pcie_mdio_write in ssb_pcicore_serdes_workaround
drivers/ssb/driver_pcicore.c, 508:
ssb_pcicore_serdes_workaround in ssb_pcicore_pcie_setup_workarounds
drivers/ssb/driver_pcicore.c, 729:
ssb_pcicore_pcie_setup_workarounds in ssb_pcicore_dev_irqvecs_enable
drivers/net/ethernet/broadcom/b44.c, 1289:
ssb_pcicore_dev_irqvecs_enable in b44_chip_reset
drivers/net/ethernet/broadcom/b44.c, 1412:
b44_chip_reset in b44_init_hw
drivers/net/ethernet/broadcom/b44.c, 2533:
b44_init_hw in b44_resume
drivers/net/ethernet/broadcom/b44.c, 2531:
spin_lock_irq in b44_resume
These bugs are found by my static analysis tool DSAC.
Best wishes,
Jia-Ju Bai
reply other threads:[~2018-09-15 8:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7c5e6bf-867b-496b-c3e0-ce5766a33d26@gmail.com \
--to=baijiaju1990@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox