From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D40FEC432BE for ; Tue, 10 Aug 2021 09:39:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B6375610A4 for ; Tue, 10 Aug 2021 09:39:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236860AbhHJJjh (ORCPT ); Tue, 10 Aug 2021 05:39:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235380AbhHJJjf (ORCPT ); Tue, 10 Aug 2021 05:39:35 -0400 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 421DBC0613D3 for ; Tue, 10 Aug 2021 02:39:14 -0700 (PDT) Received: by mail-pl1-x62c.google.com with SMTP id a20so20262839plm.0 for ; Tue, 10 Aug 2021 02:39:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=d2E0nG0ETTBn0qq2WtjDtUP2gKLM8j/WmW5ppqAkkg8=; b=A2FC6YVRnrbJky/X230btGVDIvNmMKK6QSI2D/wBl4d/0+sfaKo9RCHksE+aKih0Ik aRTZoPudgxzvrn74nSgpfXEkaD428QLeY7TSmQdoK/YHLHRQdcP8KfBq+gwNmcw4tGfK Hr+KGoePwNBBtazLDiEOpxASCMRTsL+CtMsTPGj7jGK3l6yrGqWm5uOaMYm+0WS/RXMK IaoXRHTrG1LNXv2eeakRx9frNKeN/9t0eWxKE8YewTO2eoADhZ3yZm7vfmPZCECyqc3r H4nh0Lr4qMm1Rsu/MYM19/rHWX/1zwi5PvPbCiF1d4yfZbyOzKVW0rQc5LjTKIEKoI6W UU/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=d2E0nG0ETTBn0qq2WtjDtUP2gKLM8j/WmW5ppqAkkg8=; b=e7o2phpVoGU60Jab1Xks8jxjzYEWDiMh7CS2KJfKnsKYtZPjnDN7kb22uZjTOjk0tV jY5S/FFsUCnX3WZPoE70rL3VqeEtJAyKM0LnvgvLagxMHGA2kH5EiN5PQ7TKIknm3eVm oEoHdIMfMiBJUaY/aLDK1YfjLOtmjf+eU8Btkn0Ef0OSHfoQj+7mBw5i7lzlAuLG8Aj9 /htUs+93J54E+I6UUz1Wvl7QZHjYddrPvHEj9U3d7n8+cK0dA7qkFUU7Kc/RtcA3dh95 MVryybHJ2F4HgkhWngklSauVeMOONWCoWxdp0PlQ7YFTVgXymeOJyUgGriAyvyrHz7qV JaPQ== X-Gm-Message-State: AOAM531BpSJhu51B8MmfYFaTNLKEri9gHxEE1F3TyhrklY5s74rJkDXN FuQxYuBCBeX0GF0Ly2jyjeU= X-Google-Smtp-Source: ABdhPJxfGoefCLJk5m9Jm8dL5mNDqbHcitgpCjrQAWUSxA204UMrkIqUfJu3N3ayi3QsKt/gbqF/Yw== X-Received: by 2002:a17:90a:9292:: with SMTP id n18mr4055164pjo.120.1628588353869; Tue, 10 Aug 2021 02:39:13 -0700 (PDT) Received: from [192.168.1.22] (amarseille-551-1-7-65.w92-145.abo.wanadoo.fr. [92.145.152.65]) by smtp.gmail.com with ESMTPSA id v15sm23305554pff.105.2021.08.10.02.39.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Aug 2021 02:39:13 -0700 (PDT) Subject: Re: [RFC PATCH net-next 4/4] net: dsa: b53: express b53_for_each_port in terms of dsa_switch_for_each_port To: Vladimir Oltean , netdev@vger.kernel.org, Jakub Kicinski , "David S. Miller" Cc: Andrew Lunn , Vivien Didelot , Vladimir Oltean , Kurt Kanzenbach , Woojung Huh , UNGLinuxDriver@microchip.com, Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , George McCollister References: <20210809190320.1058373-1-vladimir.oltean@nxp.com> <20210809190320.1058373-5-vladimir.oltean@nxp.com> From: Florian Fainelli Message-ID: Date: Tue, 10 Aug 2021 02:39:08 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210809190320.1058373-5-vladimir.oltean@nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 8/9/2021 12:03 PM, Vladimir Oltean wrote: > Merging the two allows us to remove the open-coded > "dev->enabled_ports & BIT(i)" check from b53_br_join and b53_br_leave, > while still avoiding a quadratic iteration through the switch's ports. > > Sadly I don't know if it's possible to completely get rid of > b53_for_each_port and replace it with dsa_switch_for_each_available_port, > especially for the platforms that use pdata and not OF bindings. > > Signed-off-by: Vladimir Oltean We should really be able to eliminate b53_for_each_port() entirely, let me try to submit a patch doing that when I come back from vacation or you can do it, and if there are bugs, I will address them. -- Florian