Netdev List
 help / color / mirror / Atom feed
From: Denys Fedoryshchenko <denys@visp.net.lb>
To: Eric Dumazet <eric.dumazet@gmail.com>, <netdev@vger.kernel.org>
Subject: Re: Re: kernel 3.7.6, l2tp, qdisc_tx circular locking
Date: Sat, 16 Feb 2013 00:54:51 +0200	[thread overview]
Message-ID: <f7eac976327ae563a2ab0fe313474128@visp.net.lb> (raw)

Sorry accidentaly deleted my emails, i will try in next 2 days to 
update server with l2tp, and will test everything there, if i can 
reproduce bug.

>diff --git a/net/l2tp/l2tp_core.c b/net/l2tp/l2tp_core.c
>index dcfd64e..7baf88f 100644
>--- a/net/l2tp/l2tp_core.c
>+++ b/net/l2tp/l2tp_core.c
>@@ -1251,8 +1251,11 @@ int l2tp_xmit_skb(struct l2tp_session *session, 
> struct sk_buff *skb, int hdr_len
> 	}
>
> 	l2tp_skb_set_owner_w(skb, sk);
>+	bh_unlock_sock(sk);
>
> 	l2tp_xmit_core(session, skb, fl, data_len);
>+	return ret;
>+
> out_unlock:
> 	bh_unlock_sock(sk);

---
Denys Fedoryshchenko, Network Engineer, Virtual ISP S.A.L.

                 reply	other threads:[~2013-02-15 22:54 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7eac976327ae563a2ab0fe313474128@visp.net.lb \
    --to=denys@visp.net.lb \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox