From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54A6830F55B for ; Thu, 16 Jul 2026 15:39:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784216354; cv=none; b=uVtuveRttWnroqgd+LO//rqcpxHAh1t9wF0jIS0j8eZMYUowPi2QZoOxEGTVJp9LkWafehRQ3cBgrIUJk8c/rJxSw2ZTvoKaEIeI6f+5cwNK02d/azVkc/hHVwrrnVIJ2qS+Mq1ZDQcjp35hLbdSUsHxSkY4L3uSE57xcPV/Xho= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784216354; c=relaxed/simple; bh=fJwqMShUqOlilhsR2xnTWpMdymtj2MusRkCVGdtttAc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=lij+9PrSQL9puhmLiCi17oFxTkV/XXayISrbfEZoUNSk8x2rY1HihCCOaCvJtL7yP53twv3OwMpQ5b09h3X0Lboyk0NXEMTTvugI8qUg/4E8tLMviE2IDsHr0moxrtCT3WHKHeogQJI4e7kPwByvWhvsBVA1KqU09fPAa9x1Id8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=cP4npYsd; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cP4npYsd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784216351; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ywt/ANbLialridvKPDjU7bqRu8QoG+XV01JI2YkMq50=; b=cP4npYsdqWgQEuaOLTqQ1e5iKf1QAdRFIQ88v/UgsbB2tcxk/ICdO0/4zLAPbDGqc2r2LG eezXKFQNIPE6f/CZRidKN5L/k2rIusWkFAnaidM694qrabyLGNK+UKLbC+v0b8gf0wldKm wdIMxvGCplTa52EO12wJdvJ0CIhwNyg= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-643--E9sVNTZMmuic514vYpV-g-1; Thu, 16 Jul 2026 11:39:06 -0400 X-MC-Unique: -E9sVNTZMmuic514vYpV-g-1 X-Mimecast-MFC-AGG-ID: -E9sVNTZMmuic514vYpV-g_1784216344 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1735C1954239; Thu, 16 Jul 2026 15:39:04 +0000 (UTC) Received: from RHTRH0061144 (unknown [10.22.81.35]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D5FB21955D86; Thu, 16 Jul 2026 15:39:00 +0000 (UTC) From: Aaron Conole To: "Matthieu Baerts (NGI0)" Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Shuah Khan , netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Eelco Chaudron , Ilya Maximets , dev@openvswitch.org Subject: Re: [PATCH net 2/7] selftests: openvswitch: add config file In-Reply-To: <20260710-net-sft-fix-containers-v1-2-a2915c294ef5@kernel.org> (Matthieu Baerts's message of "Fri, 10 Jul 2026 20:04:42 +0200") References: <20260710-net-sft-fix-containers-v1-0-a2915c294ef5@kernel.org> <20260710-net-sft-fix-containers-v1-2-a2915c294ef5@kernel.org> Date: Thu, 16 Jul 2026 11:38:54 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Hi Matthieu, "Matthieu Baerts (NGI0)" writes: > The kselftests doc mentions that a config file should be present "if a > test needs specific kernel config options enabled". This selftest > requires some kernel config, but no config file was provided. > > We could say that a sub-target could use the parent's config file, but > the kselftests doc doesn't mention anything about that. Plus the > net/openvswitch target is the only net target without a config file. We've been operating on that assumption from the openvswitch side, but it's true that isn't explicitly documented anywhere, and I guess it isn't officially supported in the kselftest framework. I guess we'll need to keep updating this config as we add tests for things like SCTP, and others, and maybe that's a good thing like we can add a comment describing which tests take which configs. The downside is for most of the OVS testing we use the NIPA scripts and those 'inherit' the parent config, so it would be a change on our side from the development standpoint (but probably something we should have been doing from the beginning). That said, would it be worth also exploring the 'cascading configuration' support? It seems like a useful feature, but maybe it should be a separate discussion. I ask because of how OVS interacts with the networking stack as an 'alternative bridge' so-to-speak, I do worry about having to duplicate lots of configurations between the two as we expand the test coverage on OVS side. > Here is a new config file, which is a trimmed version of the net one, > with hopefully the minimal required kconfig on top of 'make defconfig'. Should this also remove the OVS configs from the upper level since there shouldn't be OVS tests executing there (ie: CONFIG_OPENVSWITCH*)? > The Fixes tag points to the introduction of the net/openvswitch target, > just to help validating this target on stable kernels. > > Fixes: 25f16c873fb1 ("selftests: add openvswitch selftest suite") > Signed-off-by: Matthieu Baerts (NGI0) > --- > To: Aaron Conole > To: Eelco Chaudron > To: Ilya Maximets > Cc: dev@openvswitch.org > --- > tools/testing/selftests/net/openvswitch/config | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/tools/testing/selftests/net/openvswitch/config b/tools/testing/selftests/net/openvswitch/config > new file mode 100644 > index 000000000000..c659749cd086 > --- /dev/null > +++ b/tools/testing/selftests/net/openvswitch/config > @@ -0,0 +1,16 @@ > +CONFIG_GENEVE=m > +CONFIG_INET_DIAG=y > +CONFIG_IPV6=y > +CONFIG_NETFILTER=y > +CONFIG_NET_IPGRE=m > +CONFIG_NET_IPGRE_DEMUX=m > +CONFIG_NF_CONNTRACK=m > +CONFIG_NF_CONNTRACK_OVS=y > +CONFIG_OPENVSWITCH=m > +CONFIG_OPENVSWITCH_GENEVE=m > +CONFIG_OPENVSWITCH_GRE=m > +CONFIG_OPENVSWITCH_VXLAN=m > +CONFIG_PSAMPLE=m > +CONFIG_VETH=y > +CONFIG_VLAN_8021Q=y > +CONFIG_VXLAN=m