From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92024145B09 for ; Tue, 2 Jul 2024 11:47:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719920853; cv=none; b=Df7pjCqbmLB5S2m2qIR6SAvDJf+J+3b9Ji1/7OmDqdcMP6LRWJarRoVPIcTxM7ZeskzOvCamQGLluBLuBATmoZ9zVAC1sdW6oMPTjhFLdDN99HNaJ/iJ+SZLtP8KGqFM5eQfStg2WegdpYgr+I106TcSJK1a8pLqPC6a/LnFjpQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719920853; c=relaxed/simple; bh=FglxcTnzwOQwmJlE5WNCXHTrByMhmiPk6znqE6jdt1Y=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=lLaO7fICCheR/+TY+4QHTKkiXzoSBSbOSN3AWICloZdaRoGO8LJmgC+vxnmOthiDbd4NhNAvufEtg7nSsR9SNY4Y3S1ruODPSedd0RTrFpWscGB8sGExXh0j0AYjXXrnsKY48yHj1uBUsIvMrF8UV1P53WA5rxKVTsetbZvTYV0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=WzF7k7hb; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WzF7k7hb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719920850; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FglxcTnzwOQwmJlE5WNCXHTrByMhmiPk6znqE6jdt1Y=; b=WzF7k7hb9J6aC0fUEQ2xXqEtMbascZNL9JplZYu0nh3S+Qm6An/CVk4+W6ujGGdWnxO0Pq bbVqmjcKfpZ6leQHuzefIKWyAxzQslUc2MPbOK5+tYaElc0pUb3ztiYE3oJ8c3hadk686W 3HIcFJfqKs50e8b5Cxxwof09pjmCgbk= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-671-CMqW4YMWNiaOc1-uPSWZvg-1; Tue, 02 Jul 2024 07:47:27 -0400 X-MC-Unique: CMqW4YMWNiaOc1-uPSWZvg-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E632E1955F0D; Tue, 2 Jul 2024 11:47:25 +0000 (UTC) Received: from RHTRH0061144 (unknown [10.22.8.184]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 64B2C19560A3; Tue, 2 Jul 2024 11:47:22 +0000 (UTC) From: Aaron Conole To: Adrian Moreno Cc: netdev@vger.kernel.org, echaudro@redhat.com, horms@kernel.org, i.maximets@ovn.org, dev@openvswitch.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Donald Hunter , Pravin B Shelar , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v8 05/10] net: openvswitch: add psample action In-Reply-To: <20240702095336.596506-6-amorenoz@redhat.com> (Adrian Moreno's message of "Tue, 2 Jul 2024 11:53:22 +0200") References: <20240702095336.596506-1-amorenoz@redhat.com> <20240702095336.596506-6-amorenoz@redhat.com> Date: Tue, 02 Jul 2024 07:47:20 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 Adrian Moreno writes: > Add support for a new action: psample. > > This action accepts a u32 group id and a variable-length cookie and uses > the psample multicast group to make the packet available for > observability. > > The maximum length of the user-defined cookie is set to 16, same as > tc_cookie, to discourage using cookies that will not be offloadable. > > Reviewed-by: Ilya Maximets > Acked-by: Eelco Chaudron > Signed-off-by: Adrian Moreno > --- Reviewed-by: Aaron Conole