From: Aaron Conole <aconole@redhat.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Minxi Hou <houminxi@gmail.com>,
netdev@vger.kernel.org, davem@davemloft.net,
echaudro@redhat.com, edumazet@google.com, horms@kernel.org,
i.maximets@ovn.org, kuba@kernel.org, shuah@kernel.org,
dev@openvswitch.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] selftests/openvswitch: guard command substitutions against empty output
Date: Tue, 09 Jun 2026 08:54:45 -0400 [thread overview]
Message-ID: <f7tbjdjg9gq.fsf@redhat.com> (raw)
In-Reply-To: <c530d07f-5841-4bfb-b296-b47fc0ce0614@redhat.com> (Paolo Abeni's message of "Tue, 9 Jun 2026 12:56:17 +0200")
Paolo Abeni <pabeni@redhat.com> writes:
> On 6/1/26 1:53 PM, Minxi Hou wrote:
>> When ip-link output is unavailable, when the upcall daemon log has not
>> been written yet, or when pahole does not know the OVS drop subsystem
>> ID, the affected command substitutions silently produce empty strings.
>> The caller then passes empty sha= or pid= arguments to ovs_add_flow,
>> or matches against wrong drop reason codes, all without a diagnostic.
>>
>> Add [ -z ] guards immediately after each assignment. For test_arp_ping,
>> also align the MAC extraction to use awk '/link\/ether/' as in
>> test_pop_vlan. The drop_reason guard returns ksft_skip because an
>> absent subsystem ID is an environment issue, not a test failure.
>>
>> Signed-off-by: Minxi Hou <houminxi@gmail.com>
>
> IMHO this is net-next material.
>
> @Aaron, @Eelco, @Ilya: WDYT?
Agreed.
> /P
prev parent reply other threads:[~2026-06-09 12:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 11:53 [PATCH] selftests/openvswitch: guard command substitutions against empty output Minxi Hou
2026-06-09 10:56 ` Paolo Abeni
2026-06-09 12:54 ` Aaron Conole [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7tbjdjg9gq.fsf@redhat.com \
--to=aconole@redhat.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=houminxi@gmail.com \
--cc=i.maximets@ovn.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox