From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D648E288CA6 for ; Mon, 30 Jun 2025 12:13:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751285627; cv=none; b=U9G4YiL1r0H0Au2Jjx3AHGqHbJ3tpf0ijlBHVsvmWJeP+CuKbZcZ9ZNo8/XsIVxnJAY4SK3pBxlQbp+DBCz4Cusp8LBvTzpmYW/c+5MytKlwoLktCe0VCNymiasKFOIImYkqGjTV7VgPa/Vqdg1ybnJXKYJdnlsjixm//SzUwhc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751285627; c=relaxed/simple; bh=iY2ch4jUqZ25v6X/XWGTFLWn3SG9VMQxDqdWMCyFNEE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=lrJNjKnDxyN9vq3qiWy31pHWdgDxnGVuyIx+bM8rdWRxSK+j0rF0lCl3Xeydcuv6GlluI4sxNv6/PsofVPoW42VXc1JOmtgUPayAZ07gSpx7qzeZx4G0kPMbz9yO6qAtfuKjTsTi7He/jSczE6UK7QHbInbeEsqYgP4P57DurKM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Cw2UQQ8Y; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Cw2UQQ8Y" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751285624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WdpPBSnOitHeeR2UYouwW9SFYJlysBLXxw2KZq2UsIg=; b=Cw2UQQ8YiH/S6V3mDoR3XN+8H75lel1nfDad2PwOY6BKf7odVmd6pgKa0J986oCmyeWsVF DprSYdIHKN/fvOAkK3/IlUujrxLtf5LU6ZFEGKDKL2YHll6eUwZ7+xv7hDEUmTruqAMyNo 4QP7+7yb1nPb1QZwDWs8i3U1Nhk8vDA= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-426-Z8LOzH3YNHez3LwolDL08w-1; Mon, 30 Jun 2025 08:13:40 -0400 X-MC-Unique: Z8LOzH3YNHez3LwolDL08w-1 X-Mimecast-MFC-AGG-ID: Z8LOzH3YNHez3LwolDL08w_1751285618 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AD6611800287; Mon, 30 Jun 2025 12:13:37 +0000 (UTC) Received: from RHTRH0061144 (unknown [10.22.89.10]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 358E818003FC; Mon, 30 Jun 2025 12:13:33 +0000 (UTC) From: Aaron Conole To: Eric Dumazet Cc: Stephen Hemminger , dev@openvswitch.org, netdev@vger.kernel.org, Andrew Lunn , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eelco Chaudron , Ilya Maximets , =?utf-8?Q?Adri=C3=A1n?= Moreno , Mike Pattrick , Florian Westphal , John Fastabend , Jakub Sitnicki , Joe Stringer Subject: Re: [RFC] net: openvswitch: Inroduce a light-weight socket map concept. In-Reply-To: (Eric Dumazet's message of "Mon, 30 Jun 2025 03:07:54 -0700") References: <20250627210054.114417-1-aconole@redhat.com> <20250627145532.500a3ae3@hermes.local> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Mon, 30 Jun 2025 08:13:32 -0400 Message-ID: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Eric Dumazet writes: > On Fri, Jun 27, 2025 at 2:55=E2=80=AFPM Stephen Hemminger > wrote: >> >> On Fri, 27 Jun 2025 17:00:54 -0400 >> Aaron Conole wrote: >> >> > diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c >> > index 429fb34b075e..f43f905b1cb0 100644 >> > --- a/net/ipv4/tcp_ipv4.c >> > +++ b/net/ipv4/tcp_ipv4.c >> > @@ -93,6 +93,7 @@ static int tcp_v4_md5_hash_hdr(char *md5_hash, >> > const struct tcp_md5sig_key *key, >> > #endif >> > >> > struct inet_hashinfo tcp_hashinfo; >> > +EXPORT_SYMBOL(tcp_hashinfo); >> >> EXPORT_SYMBOL_GPL seems better here > > Even better, not use tcp_hashinfo at all, it will break for netns > having private hash tables. > > Instead use : > > struct inet_hashinfo *hinfo =3D net->ipv4.tcp_death_row.hashinfo Thanks Eric - I'll make sure to use that in future.