From: Aaron Conole <aconole@redhat.com>
To: Aleksei Oladko <aleksey.oladko@virtuozzo.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
Ilya Maximets <imaximet@redhat.com>,
Eelco Chaudron <echaudro@redhat.com>,
Stefano Brivio <sbrivio@redhat.com>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, dev@openvswitch.org
Subject: Re: [PATCH net v3 2/6] selftests: net: make ovs-dpctl.py fail when pyroute2 is unsupported
Date: Fri, 06 Mar 2026 08:42:25 -0500 [thread overview]
Message-ID: <f7tfr6dqdku.fsf@redhat.com> (raw)
In-Reply-To: <20260306000127.519064-3-aleksey.oladko@virtuozzo.com> (Aleksei Oladko's message of "Fri, 6 Mar 2026 00:01:23 +0000")
Aleksei Oladko <aleksey.oladko@virtuozzo.com> writes:
> The pmtu.sh kselftest configures OVS using ovs-dpctl.py and falls back
> to ovs-vsctl only when ovs-dpctl.py fails. However, ovs-dpctl.py exits
> with a success status when the installed pyroute2 package version is
> lower than 0.6, even though the OVS datapath is not configured.
>
> As a result, pmtu.sh assumes that the setup was successful and
> continues running the test, which later fails due to the missing
> OVS configuration.
>
> Fix the exit code handling in ovs-dpctl.py so that pmtu.sh can detect
> that the setup did not complete successfully and fall back to
> ovs-vsctl.
>
> Fixes: 962e8a01eab9 ("selftests: openvswitch: Add version check for pyroute2")
> Signed-off-by: Aleksei Oladko <aleksey.oladko@virtuozzo.com>
> ---
This change looks good to me.
Reviewed-by: Aaron Conole <aconole@redhat.com>
next prev parent reply other threads:[~2026-03-06 13:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 0:01 [PATCH net v3 0/6] selftests: net: fix false failures due to missing features and host interference Aleksei Oladko
2026-03-06 0:01 ` [PATCH net v3 1/6] selftests: net: fib_tests: skip rp_filter test if cls_basic is unavailable Aleksei Oladko
2026-03-07 3:24 ` Jakub Kicinski
2026-03-06 0:01 ` [PATCH net v3 2/6] selftests: net: make ovs-dpctl.py fail when pyroute2 is unsupported Aleksei Oladko
2026-03-06 13:42 ` Aaron Conole [this message]
2026-03-06 0:01 ` [PATCH net v3 3/6] selftests: net: run reuseport tests in netns to avoid port conflicts Aleksei Oladko
2026-03-07 3:25 ` Jakub Kicinski
2026-03-06 0:01 ` [PATCH net v3 4/6] selftests: net: rename pmtu.sh to pmtu-test.sh Aleksei Oladko
2026-03-06 0:01 ` [PATCH net v3 5/6] selftests: net: run pmtu.sh in netns to avoid host firewall interference Aleksei Oladko
2026-03-06 0:01 ` [PATCH net v3 6/6] selftests: net: io_uring_zerocopy: enable io_uring for the test Aleksei Oladko
2026-03-07 3:50 ` [PATCH net v3 0/6] selftests: net: fix false failures due to missing features and host interference patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7tfr6dqdku.fsf@redhat.com \
--to=aconole@redhat.com \
--cc=aleksey.oladko@virtuozzo.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=imaximet@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbrivio@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox