From: Aaron Conole <aconole@redhat.com>
To: Hyunwoo Kim <v4bel@theori.io>
Cc: pshelar@ovn.org, edumazet@google.com, dev@openvswitch.org,
netdev@vger.kernel.org, imv4bel@gmail.com, kuba@kernel.org,
pabeni@redhat.com, davem@davemloft.net
Subject: Re: [ovs-dev] [PATCH] net: openvswitch: Fix Use-After-Free in ovs_ct_exit
Date: Wed, 24 Apr 2024 10:58:59 -0400 [thread overview]
Message-ID: <f7tfrvabydo.fsf@redhat.com> (raw)
In-Reply-To: <ZiYvzQN/Ry5oeFQW@v4bel-B760M-AORUS-ELITE-AX> (Hyunwoo Kim's message of "Mon, 22 Apr 2024 05:37:17 -0400")
Hyunwoo Kim <v4bel@theori.io> writes:
> Since kfree_rcu, which is called in the hlist_for_each_entry_rcu traversal
> of ovs_ct_limit_exit, is not part of the RCU read critical section, it
> is possible that the RCU grace period will pass during the traversal and
> the key will be free.
>
> To prevent this, it should be changed to hlist_for_each_entry_safe.
>
> Fixes: 11efd5cb04a1 ("openvswitch: Support conntrack zone limit")
> Signed-off-by: Hyunwoo Kim <v4bel@theori.io>
> ---
Reviewed-by: Aaron Conole <aconole@redhat.com>
next prev parent reply other threads:[~2024-04-24 14:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 9:37 [PATCH] net: openvswitch: Fix Use-After-Free in ovs_ct_exit Hyunwoo Kim
2024-04-22 10:40 ` Eric Dumazet
2024-04-24 14:58 ` Aaron Conole [this message]
2024-04-25 2:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7tfrvabydo.fsf@redhat.com \
--to=aconole@redhat.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=edumazet@google.com \
--cc=imv4bel@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pshelar@ovn.org \
--cc=v4bel@theori.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).