From: Aaron Conole <aconole@redhat.com>
To: Simon Horman <simon.horman@corigine.com>
Cc: Eelco Chaudron <echaudro@redhat.com>,
wangchuanlei <wangchuanlei@inspur.com>,
dev@openvswitch.org, netdev@vger.kernel.org,
wangpeihui@inspur.com, kuba@kernel.org, pabeni@redhat.com,
davem@davemloft.net
Subject: Re: [ovs-dev] [PATCH net v2] net: openvswitch: fix upcall counter access before allocation
Date: Mon, 12 Jun 2023 11:06:21 -0400 [thread overview]
Message-ID: <f7tfs6w3eky.fsf@redhat.com> (raw)
In-Reply-To: <ZIGWcLy8ivB6IeGK@corigine.com> (Simon Horman's message of "Thu, 8 Jun 2023 10:50:56 +0200")
Simon Horman <simon.horman@corigine.com> writes:
> On Wed, Jun 07, 2023 at 11:09:58AM +0200, Eelco Chaudron wrote:
>
> ...
>
>> >> We moved the per cpu upcall counter allocation to the existing vport
>> >> alloc and free functions to solve this.
>> >>
>> >> Fixes: 95637d91fefd ("net: openvswitch: release vport resources on
>> >> failure")
>> >> Fixes: 1933ea365aa7 ("net: openvswitch: Add support to count upcall
>> >> packets")
>> >> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
>> >> ---
>> >
>> > Acked-by: Aaron Conole <aconole@redhat.com>
>>
>> Were you intentionally ACKing this on Aaron’s behalf? Or just a cut/paste error ;)
>
> I was wondering that too.
> But then I concluded it was an artifact of top-posting or some
> other behaviour of the mail client.
Thankfully, I did ack the patch, but yes, this is something to be
careful.
To wangchuanlei <wangchuanlei@inspur.com>, please read
https://people.kernel.org/tglx/
Specifically, do not top-post for this and other reasons.
prev parent reply other threads:[~2023-06-12 15:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 1:05 [ovs-dev] [PATCH net v2] net: openvswitch: fix upcall counter access before allocation wangchuanlei
2023-06-07 9:09 ` Eelco Chaudron
2023-06-08 8:50 ` Simon Horman
2023-06-12 15:06 ` Aaron Conole [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7tfs6w3eky.fsf@redhat.com \
--to=aconole@redhat.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
--cc=wangchuanlei@inspur.com \
--cc=wangpeihui@inspur.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).