From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA1E116D9CA for ; Wed, 24 Apr 2024 18:14:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713982489; cv=none; b=uiXRVz06zYoDPgNEyM37Xi1qv3ICOOgVMVGzXUc6XvcVSbj/P8kBahk59p3qc4I7/mM6eKDYT/ZTDuufhpTNi4uYhDIWXJTS7rDrHTp0zPqsgkmYzfeQeH/6L5cgrP7tJS3jEk0jQkJhL3X64QVSUT3T4tvZRKDKgB9zT3jFrmU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713982489; c=relaxed/simple; bh=+4r7iLFXraZgcoLPWgj6PnzEMXZRq0mxHwRIq9rZegk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=QLaUuy83YFPAezUld3QpRSSWq4zO5g0hI5hQ4NKztk3XN55TZs7FLqoR7bD5HdxFYJo7rcp5m8N+O0CClEEl/WGyuVosIsv+/AK8pVLelOvLAEOMIclN9Z117LlgR9TWcVyMFv5L5qUwg8ghvG8cAfCG2RlWZqS23ds1D8lesEI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=XGG1QpJd; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XGG1QpJd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713982486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ll6LtsSB3IShWEfWe8TsPKTtwPqmZYYtwit4iQKiJxY=; b=XGG1QpJdu00Z9+dDb/JKjt/UXVfQtwXmvSZoNIikPnsS071d3OZbmstfYtrH08th7eHsOS 8yUYaPPlI4pgE/OKzdcLJD+MVphwJtkimsa9kY/tJlFrd98KCRTd/HPd+PajQtTBxGhvs0 pMERDKbftdmUJrc9w8P1QtmVV+fya7Y= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-403-5G_tJbtIN1SpBo_XTRU4Zg-1; Wed, 24 Apr 2024 14:14:43 -0400 X-MC-Unique: 5G_tJbtIN1SpBo_XTRU4Zg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2DCF929AA3B0; Wed, 24 Apr 2024 18:14:43 +0000 (UTC) Received: from RHTRH0061144 (dhcp-17-72.bos.redhat.com [10.18.17.72]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EC6EF492BC6; Wed, 24 Apr 2024 18:14:42 +0000 (UTC) From: Aaron Conole To: Benjamin Poirier Cc: Simon Horman , Jakub Kicinski , dev@openvswitch.org, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, Jiri Pirko Subject: Re: [ovs-dev] selftests: openvswitch: Questions about possible enhancements In-Reply-To: (Benjamin Poirier's message of "Wed, 24 Apr 2024 13:59:29 -0400") References: <20240424164405.GN42092@kernel.org> <20240424173715.GP42092@kernel.org> Date: Wed, 24 Apr 2024 14:14:42 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 Benjamin Poirier writes: > On 2024-04-24 18:37 +0100, Simon Horman wrote: >> On Wed, Apr 24, 2024 at 05:44:05PM +0100, Simon Horman wrote: >> > Hi Aaron, Jakub, all, >> > >> > I have recently been exercising the Open vSwitch kernel selftests, >> > using vng, something like this: >> > >> > TESTDIR="tools/testing/selftests/net/openvswitch" >> > >> > vng -v --run . --user root --cpus 2 \ >> > --overlay-rwdir "$PWD" -- \ >> > "modprobe openvswitch && \ >> > echo \"timeout=90\" >> \"${TESTDIR}/settings\" && \ >> > make -C \"$TESTDIR\" run_tests" >> > >> > And I have some observations that I'd like to ask about. >> > >> > 1. Building the kernel using the following command does not >> > build the openvswitch kernel module. >> > >> > vng -v --build \ >> > --config tools/testing/selftests/net/config >> > >> > All that seems to be missing is CONFIG_OPENVSWITCH=m >> > and I am wondering what the best way of resolving this is. >> > >> > Perhaps I am doing something wrong. >> > Or perhaps tools/testing/selftests/net/openvswitch/config >> > should be created? If so, should it include (most of?) what is in >> > tools/testing/selftests/net/config, or just CONFIG_OPENVSWITCH=m? > > I noticed something similar when testing Jiri's virtio_net selftests > patchset [1]. > > drivers/net/virtio_net/config includes virtio options but the > test also needs at least CONFIG_NET_VRF=y which is part of net/config. > > Whatever the answer to your question, all config files should be > coherent on this matter. > > [1] https://lore.kernel.org/netdev/20240424104049.3935572-1-jiri@resnulli.us/ > > [...] >> >> 5. openvswitch.sh starts with "#!/bin/sh". >> But substitutions such as "${ns:0:1}0" fail if /bin/sh is dash. >> Perhaps we should change openvswitch.sh to use bash? > > I think so. A similar change was done in > c2518da8e6b0 selftests: bonding: Change script interpreter (v6.8-rc1) +1 - I'm okay with it.