From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F11452583 for ; Mon, 24 Jul 2023 14:34:44 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAD0F120 for ; Mon, 24 Jul 2023 07:34:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690209283; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=usaX6souPQgHJnRNd8w4HymicnwhPqVsN+QpbZMCn+k=; b=CuZZNwkpy+/wFPR+KJn4RAoQ/nO3Rv0DnNqSPTDbcpHpX1av7GCkmfMoOVR3+XUyYvcPtD BwOtPUm1JiwUTil37uVUNcWygX6RYzyb7XCVfUKTRvHx9pGT2YYgH/wS2xRdGxRO1HYKIA 87EmP2J0QuJ8ZDkty3HmUFH+99TvfsM= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-692-lO5xUtC3Nw2M-8BaZZ1JvA-1; Mon, 24 Jul 2023 10:34:39 -0400 X-MC-Unique: lO5xUtC3Nw2M-8BaZZ1JvA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 319283810D36; Mon, 24 Jul 2023 14:34:39 +0000 (UTC) Received: from RHTPC1VM0NT (unknown [10.22.33.15]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 39D3B2166B25; Mon, 24 Jul 2023 14:34:38 +0000 (UTC) From: Aaron Conole To: Adrian Moreno Cc: netdev@vger.kernel.org, dev@openvswitch.org, i.maximets@ovn.org, eric@garver.life, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: Re: [PATCH net-next 0/7] openvswitch: add drop reasons References: <20230722094238.2520044-1-amorenoz@redhat.com> Date: Mon, 24 Jul 2023 10:34:37 -0400 In-Reply-To: <20230722094238.2520044-1-amorenoz@redhat.com> (Adrian Moreno's message of "Sat, 22 Jul 2023 11:42:30 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Adrian Moreno writes: > There is currently a gap in drop visibility in the openvswitch module. > This series tries to improve this by adding a new drop reason subsystem > for OVS. > > Apart from adding a new drop reasson subsystem and some common drop > reasons, this series takes Eric's preliminary work [1] on adding an > explicit drop action and integrates it into the same subsystem. > > This series also adds some selftests and so it requires [2] to be > applied first. > > A limitation of this series is that it does not report upcall errors. > The reason is that there could be many sources of upcall drops and the > most common one, which is the netlink buffer overflow, cannot be > reported via kfree_skb() because the skb is freed in the netlink layer > (see [3]). Therefore, using a reason for the rare events and not the > common one would be even more misleading. I'd propose we add (in a > follow up patch) a tracepoint to better report upcall errors. I guess you meant to add RFC tag to this, since it depends on other series that aren't accepted yet. If it's okay, I will pull in your patch 5/7 when I re-post my flow additions series, since it will need to be added there at some point anyway. > [1] https://lore.kernel.org/netdev/202306300609.tdRdZscy-lkp@intel.com/T/ > [2] https://lore.kernel.org/all/9375ccbc-dd40-9998-dde5-c94e4e28f4f1@redhat.com/T/ > [3] commit 1100248a5c5c ("openvswitch: Fix double reporting of drops in dropwatch") > > Adrian Moreno (6): > net: openvswitch: add datapath flow drop reason > net: openvswitch: add meter drop reason > net: openvswitch: add misc error drop reasons > selftests: openvswitch: support key masks > selftests: openvswitch: add drop reason testcase > selftests: openvswitch: add explicit drop testcase > > Eric Garver (1): > net: openvswitch: add explicit drop action > > include/net/dropreason.h | 6 + > include/uapi/linux/openvswitch.h | 2 + > net/openvswitch/actions.c | 40 ++++-- > net/openvswitch/conntrack.c | 3 +- > net/openvswitch/datapath.c | 16 +++ > net/openvswitch/drop.h | 33 +++++ > net/openvswitch/flow_netlink.c | 8 +- > .../selftests/net/openvswitch/openvswitch.sh | 92 +++++++++++++- > .../selftests/net/openvswitch/ovs-dpctl.py | 115 ++++++++++++------ > 9 files changed, 267 insertions(+), 48 deletions(-) > create mode 100644 net/openvswitch/drop.h