From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5326C1D53E for ; Fri, 26 Jan 2024 16:18:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706285940; cv=none; b=ExDlr3sDlTJGpFKuLGLrAwvUEc+E9pCiHHuD6Bodr9HK+YMMno5Xn9HgVhOsDISaA2cKXJyUbo68QFv2HrmI6lgosjHp8PpCpcjDQQ9pGUMIIC7LmW4IkVnqaZD76PNa4uv4HWGTPdcdUJ7iTNkF7AmlhrVyAHrFhk009U8vuu0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706285940; c=relaxed/simple; bh=+frgNUH2ZlZhwZP2UO21VP36KfozIuygrIl6i1D+e7w=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=pUL2GttrEQBm6WOgpCmpXw94DSfnVn9MJAw17VQbpbk0Dy48uQ1gT/4dipPDhnu6q5mr/JR0pNfQBXNG3JiVzeRg6xvU1qiO1L7Epnl+2K/BmGo2Ki8ESMFwREamG14MDz0NDCQtp1H1mYQU08x6cqXth9qYdm3sFbHiVgqUyZo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fPgVH/i/; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fPgVH/i/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706285938; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6RnvoYDcpPaS4iUg5kcJdLzlRXCzjAoYe4p9PjhV4aw=; b=fPgVH/i/BZoNvhGoX5iN1mh3Yhw/Jct+Yu+Abp17WpDUYdAesg8TfwvIw5eBRoe1QuBOYZ VFV8VlbOt3Sb4YocmbNQ9M3CK8dh+nF26cW4L92bvM3IvUAMZSi+ruJdHIXmZ3yV5H+tO7 SR7dtQIpdYjSnrWRsLgDiknXlbkj6DQ= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-155-IRAC04QZMeiIfD3hQUIYgQ-1; Fri, 26 Jan 2024 11:18:55 -0500 X-MC-Unique: IRAC04QZMeiIfD3hQUIYgQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 92C0E1C07F43; Fri, 26 Jan 2024 16:18:54 +0000 (UTC) Received: from RHTPC1VM0NT (unknown [10.22.33.141]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CE2251C060AF; Fri, 26 Jan 2024 16:18:53 +0000 (UTC) From: Aaron Conole To: Paolo Abeni Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Shuah Khan , Xin Long , Florian Westphal , Nikolay Aleksandrov , linux-kselftest@vger.kernel.org Subject: Re: [PATCH net] selftests: net: add missing config for big tcp tests References: <21630ecea872fea13f071342ac64ef52a991a9b5.1706282943.git.pabeni@redhat.com> Date: Fri, 26 Jan 2024 11:18:53 -0500 In-Reply-To: <21630ecea872fea13f071342ac64ef52a991a9b5.1706282943.git.pabeni@redhat.com> (Paolo Abeni's message of "Fri, 26 Jan 2024 16:32:36 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 Paolo Abeni writes: > The big_tcp test-case requires a few kernel knobs currently > not specified in the net selftests config, causing the > following failure: > > # selftests: net: big_tcp.sh > # Error: Failed to load TC action module. > # We have an error talking to the kernel > ... > # Testing for BIG TCP: > # CLI GSO | GW GRO | GW GSO | SER GRO > # ./big_tcp.sh: line 107: test: !=: unary operator expected > ... > # on on on on : [FAIL_on_link1] > > Add the missing configs > > Fixes: 6bb382bcf742 ("selftests: add a selftest for big tcp") > Signed-off-by: Paolo Abeni > --- Thanks for the fix. Maybe we should also add the config for NET_ACT_CT since we will invoke it on setup. I guess there's some dependency that must be pulling it in for us already so we don't explicitly call for it, but we do require it in setup() if I understand correctly. I don't think it should hold up this patch though. Acked-by: Aaron Conole